Skip to content

ci: add update-maintainers.yml; all-maintainers.nix: initial creation #7350

Merged
khaneliman merged 3 commits intonix-community:masterfrom
khaneliman:maintainer-list
Jul 1, 2025
Merged

ci: add update-maintainers.yml; all-maintainers.nix: initial creation #7350
khaneliman merged 3 commits intonix-community:masterfrom
khaneliman:maintainer-list

Conversation

@khaneliman
Copy link
Copy Markdown
Collaborator

Description

Helps with something we started talking about a while back with #6921 which required some changes to allow requesting reviews from maintainers. @zowoq created nix-community/infra#1837 to try and see if we can get maintainers invited to a team that will allow github api to request reviews from people. This provides a nix file for that process to read and send invites.

Untested CI flow, but the script works and can be maintained manually until ci is verified working.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

Create a script for generating the master maintainer list we will use
for inviting / pinging on changed files.

Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Create initial master maintainer list from the home manager and nixpkgs
maintainers that are referenced in the repository.

Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Create workflow for updating maintainers list.

Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
@zowoq
Copy link
Copy Markdown
Contributor

zowoq commented Jul 1, 2025

Once this is merged I'll rename the current home-manager team to home-manager-committers, create a home-manager-maintainer team and deploy nix-community/infra#1837.

@khaneliman khaneliman merged commit 77bb9e0 into nix-community:master Jul 1, 2025
3 checks passed
@khaneliman khaneliman deleted the maintainer-list branch July 1, 2025 21:30
@zowoq
Copy link
Copy Markdown
Contributor

zowoq commented Jul 2, 2025

Sorry, I should have checked this first before it was merged.

Three githubId are incorrectly quoted and three accounts are missing github account/id:

diff --git a/all-maintainers.nix b/all-maintainers.nix
index 3660e8ad..28cbbefa 100644
--- a/all-maintainers.nix
+++ b/all-maintainers.nix
@@ -15,7 +15,7 @@
     name = "Eulalia del Sol";
     email = "3ulalia@proton.me";
     github = "3ulalia";
-    githubId = "179992797";
+    githubId = 179992797;
   };
   # home-manager
   "9p4" = {
@@ -323,7 +323,7 @@
   henrisota = {
     email = "henrisota@users.noreply.github.com";
     github = "henrisota";
-    githubId = "56848082";
+    githubId = 56848082;
     name = "Henri Sota";
   };
   # home-manager
@@ -677,7 +677,7 @@
   msfjarvis = {
     email = "me@msfjarvis.dev";
     github = "msfjarvis";
-    githubId = "13348378";
+    githubId = 13348378;
     name = "Harsh Shandilya";
     keys = [
       {
WARN Missing GitHub ID, github_account: silmarp, exec-mode: CheckHandles, module: rfc39::op_check_handles:17
WARN Missing GitHub ID, github_account: hey2022, exec-mode: CheckHandles, module: rfc39::op_check_handles:17
ERRO Missing GitHub Account, but ID present, github_id: 43591752, who: jess, exec-mode: CheckHandles, module: rfc39::op_check_handles:21

@khaneliman
Copy link
Copy Markdown
Collaborator Author

Sorry, I should have checked this first before it was merged.

Three githubId are incorrectly quoted and three accounts are missing github account/id:

diff --git a/all-maintainers.nix b/all-maintainers.nix
index 3660e8ad..28cbbefa 100644
--- a/all-maintainers.nix
+++ b/all-maintainers.nix
@@ -15,7 +15,7 @@
     name = "Eulalia del Sol";
     email = "3ulalia@proton.me";
     github = "3ulalia";
-    githubId = "179992797";
+    githubId = 179992797;
   };
   # home-manager
   "9p4" = {
@@ -323,7 +323,7 @@
   henrisota = {
     email = "henrisota@users.noreply.github.com";
     github = "henrisota";
-    githubId = "56848082";
+    githubId = 56848082;
     name = "Henri Sota";
   };
   # home-manager
@@ -677,7 +677,7 @@
   msfjarvis = {
     email = "me@msfjarvis.dev";
     github = "msfjarvis";
-    githubId = "13348378";
+    githubId = 13348378;
     name = "Harsh Shandilya";
     keys = [
       {
WARN Missing GitHub ID, github_account: silmarp, exec-mode: CheckHandles, module: rfc39::op_check_handles:17
WARN Missing GitHub ID, github_account: hey2022, exec-mode: CheckHandles, module: rfc39::op_check_handles:17
ERRO Missing GitHub Account, but ID present, github_id: 43591752, who: jess, exec-mode: CheckHandles, module: rfc39::op_check_handles:21

Looks like issues in our maintainers list, actually. I'll fix those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants