ci: add update-maintainers.yml; all-maintainers.nix: initial creation #7350
Merged
khaneliman merged 3 commits intonix-community:masterfrom Jul 1, 2025
Merged
ci: add update-maintainers.yml; all-maintainers.nix: initial creation #7350khaneliman merged 3 commits intonix-community:masterfrom
khaneliman merged 3 commits intonix-community:masterfrom
Conversation
f41050b to
44dadbd
Compare
Create a script for generating the master maintainer list we will use for inviting / pinging on changed files. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Create initial master maintainer list from the home manager and nixpkgs maintainers that are referenced in the repository. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Create workflow for updating maintainers list. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
44dadbd to
555c343
Compare
Contributor
|
Once this is merged I'll rename the current home-manager team to home-manager-committers, create a home-manager-maintainer team and deploy nix-community/infra#1837. |
Contributor
|
Sorry, I should have checked this first before it was merged. Three githubId are incorrectly quoted and three accounts are missing github account/id: diff --git a/all-maintainers.nix b/all-maintainers.nix
index 3660e8ad..28cbbefa 100644
--- a/all-maintainers.nix
+++ b/all-maintainers.nix
@@ -15,7 +15,7 @@
name = "Eulalia del Sol";
email = "3ulalia@proton.me";
github = "3ulalia";
- githubId = "179992797";
+ githubId = 179992797;
};
# home-manager
"9p4" = {
@@ -323,7 +323,7 @@
henrisota = {
email = "henrisota@users.noreply.github.com";
github = "henrisota";
- githubId = "56848082";
+ githubId = 56848082;
name = "Henri Sota";
};
# home-manager
@@ -677,7 +677,7 @@
msfjarvis = {
email = "me@msfjarvis.dev";
github = "msfjarvis";
- githubId = "13348378";
+ githubId = 13348378;
name = "Harsh Shandilya";
keys = [
{ |
Collaborator
Author
Looks like issues in our maintainers list, actually. I'll fix those. |
This was referenced Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Helps with something we started talking about a while back with #6921 which required some changes to allow requesting reviews from maintainers. @zowoq created nix-community/infra#1837 to try and see if we can get maintainers invited to a team that will allow github api to request reviews from people. This provides a nix file for that process to read and send invites.
Untested CI flow, but the script works and can be maintained manually until ci is verified working.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC