Skip to content

disable tests for this#568

Closed
khaneliman wants to merge 3 commits intomasterfrom
test
Closed

disable tests for this#568
khaneliman wants to merge 3 commits intomasterfrom
test

Conversation

@khaneliman
Copy link
Copy Markdown
Owner

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@khaneliman khaneliman marked this pull request as draft July 2, 2025 18:27
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 18:28
@khaneliman khaneliman marked this pull request as draft July 2, 2025 18:28
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 18:28
@khaneliman khaneliman marked this pull request as draft July 2, 2025 18:29
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 18:29
@khaneliman khaneliman marked this pull request as draft July 2, 2025 18:31
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 18:31
@khaneliman khaneliman requested a review from Copilot July 2, 2025 18:34
@khaneliman khaneliman marked this pull request as draft July 2, 2025 18:34
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 18:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes temporary changes to disable certain CI triggers and adds an if condition in the maintainers tagging workflow.

  • Introduces a throwaway comment in the River module
  • Inserts an extra blank line in the launchd module
  • Removes the pull_request trigger in the Test workflow, effectively disabling tests on PRs
  • Adds an if outside of any job in the tag-maintainers workflow

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
modules/services/window-managers/river.nix Added a temporary test comment in extraDescription
modules/launchd/default.nix Inserted an unnecessary blank line before in
.github/workflows/test.yml Removed pull_request under on:, disabling PR test runs
.github/workflows/tag-maintainers.yml Placed if: at the end of the file instead of inside a job
Comments suppressed due to low confidence (3)

.github/workflows/test.yml:3

  • Removing the pull_request trigger under on: disables tests on PRs; if this was unintended, please restore it to ensure CI runs on pull requests.
  schedule:

.github/workflows/tag-maintainers.yml:124

  • The if: condition is placed outside of any job or step and will render the workflow invalid; move it under the appropriate job context.
    if: github.repository_owner == 'nix-community'

Set to `null` to not add any river package to your path.
This should be done if you want to use the NixOS river module to install river.

test change to trigger CI
Copy link

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This inline comment appears to be a temporary placeholder; consider removing it or replacing it with a meaningful description for end users.

Suggested change
test change to trigger CI
This option allows users to customize the inclusion of the river package in their environment.

Copilot uses AI. Check for mistakes.
@khaneliman khaneliman force-pushed the master branch 2 times, most recently from 15184fc to b4b1687 Compare July 2, 2025 18:43
@khaneliman khaneliman marked this pull request as draft July 2, 2025 18:43
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 18:43
@khaneliman khaneliman marked this pull request as draft July 2, 2025 18:49
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 18:49
@khaneliman khaneliman marked this pull request as draft July 2, 2025 19:27
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 19:28
Want to create an easier way to notify maintainers that someone is
working on their module.

Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
@khaneliman khaneliman marked this pull request as draft July 2, 2025 19:34
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 19:34
@github-actions github-actions bot requested a review from GaetanLepage July 2, 2025 19:35
@khaneliman
Copy link
Copy Markdown
Owner Author

Huzzah

@khaneliman khaneliman closed this Jul 2, 2025
@khaneliman khaneliman reopened this Jul 2, 2025
@khaneliman khaneliman marked this pull request as draft July 2, 2025 19:39
@khaneliman khaneliman marked this pull request as ready for review July 2, 2025 19:39
@khaneliman
Copy link
Copy Markdown
Owner Author

Looks like everything is working. Closing. :)

@khaneliman khaneliman closed this Jul 2, 2025
@khaneliman khaneliman deleted the test branch July 2, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants