Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR makes temporary changes to disable certain CI triggers and adds an if condition in the maintainers tagging workflow.
- Introduces a throwaway comment in the River module
- Inserts an extra blank line in the launchd module
- Removes the
pull_requesttrigger in the Test workflow, effectively disabling tests on PRs - Adds an
ifoutside of any job in the tag-maintainers workflow
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/services/window-managers/river.nix | Added a temporary test comment in extraDescription |
| modules/launchd/default.nix | Inserted an unnecessary blank line before in |
| .github/workflows/test.yml | Removed pull_request under on:, disabling PR test runs |
| .github/workflows/tag-maintainers.yml | Placed if: at the end of the file instead of inside a job |
Comments suppressed due to low confidence (3)
.github/workflows/test.yml:3
- Removing the
pull_requesttrigger underon:disables tests on PRs; if this was unintended, please restore it to ensure CI runs on pull requests.
schedule:
.github/workflows/tag-maintainers.yml:124
- The
if:condition is placed outside of any job or step and will render the workflow invalid; move it under the appropriate job context.
if: github.repository_owner == 'nix-community'
| Set to `null` to not add any river package to your path. | ||
| This should be done if you want to use the NixOS river module to install river. | ||
|
|
||
| test change to trigger CI |
There was a problem hiding this comment.
[nitpick] This inline comment appears to be a temporary placeholder; consider removing it or replacing it with a meaningful description for end users.
Suggested change
| test change to trigger CI | |
| This option allows users to customize the inclusion of the river package in their environment. |
15184fc to
b4b1687
Compare
Want to create an easier way to notify maintainers that someone is working on their module. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Owner
Author
|
Huzzah |
6 tasks
Owner
Author
|
Looks like everything is working. Closing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC