gtk: allow more granular customization#7349
Conversation
|
@zowoq Do you know if the Github App needs different permissions to read the team/member list ? https://github.com/nix-community/home-manager/actions/runs/16034340501/job/45242369177?pr=7349 I was able to get it to work without the app in my fork #6921 From what I have read, it looks like the github app just needs its GraphQL permissions updated in the organization. |
Sounds like the app needs "Organization permissions" -> "Members" -> "Read-only" Which I believe is configured from: https://github.com/settings/apps/home-manager-ci/permissions (as always with app perm changes, they also need "accepting" from the repo's installation, but I assume org-owners are well aware of this 😅) |
Done. |
|
@zowoq sweet, it worked thanks. we will need the same thing done for the nixvim and stylix bots too |
I'll wait until we're adding the rfc39 service for these repos to update the app permissions. |
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
We can now customize a lot more in the gtk module. Test more scenarios to ensure a user has more control over what gets generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
The file grew in complexity while adding customization. Separate concerns for each gtk versions customization and use lib helpers to consolidate logic. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Added 6 years ago, no longer needed. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
This appears to have removed the gtk.gtk2.force option. Is there a new way of forcefully overwriting? |
That would have been an accident, it should be backwards compatible. I'll fix ASAP. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/home-manager-applies-my-gtk3-theme-to-gtk4/47826/2 |
Description
This pull request refactors the GTK configuration module to improve flexibility, readability, and maintainability. Key changes include the introduction of global settings inheritance, per-version overrides for GTK2/3/4, and enhanced testing coverage for the new configuration structure.
Refactoring and Enhancements to GTK Configuration
Global Settings Inheritance:
gtk2,gtk3,gtk4).mkGtkSettingsto streamline attribute set generation for GTK settings.Per-Version Overrides:
Improved Testing Structure
Closes #5133
Closes #5900
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC