Repository navigation
[diffusion] Add MiniMax-H3 to ComfyUI integrated mode - #1
Open
niehen6174 wants to merge 1510 commits into
Open
niehen6174 wants to merge 1510 commits into
niehen6174 wants to merge 1510 commits into
Conversation
niehen6174
force-pushed
the
feat/comfyui-h3
branch
from
August 23, 2026 06:59
42aaadd to
cdf245c
Compare
niehen6174
force-pushed
the
feat/comfyui-plugin-refactor
branch
from
August 29, 2026 01:56
db76a41 to
a89d031
Compare
niehen6174
force-pushed
the
feat/comfyui-h3
branch
from
August 29, 2026 02:07
1a6f298 to
8e7d475
Compare
…oject#39524) Co-authored-by: mmangkad <mohammad.angkad@radixark.ai>
…roject#40507) Co-authored-by: Mick Qian <mickqian@users.noreply.github.com>
…_all (sgl-project#40590) Co-authored-by: Mick Qian <mickqian@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…page-table transform (sgl-project#39340) Co-authored-by: Thomas Wang <thomawan@amd.com> Co-authored-by: Kevin Mi <45493463+kevin-mii@users.noreply.github.com> Co-authored-by: Kevin Mi <mikevin920@yahoo.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…ject#35504) Co-authored-by: Po-Han Huang (NVIDIA) <53919306+nvpohanh@users.noreply.github.com>
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
…gl-project#38546) Co-authored-by: Raiden-Makoto <Raiden-Makoto@users.noreply.github.com> Co-authored-by: Thomas Wang <thomawan@amd.com> Co-authored-by: andyluo7 <andy.luo@amd.com> Co-authored-by: Kevin Mi <mikevin920@yahoo.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…oject#28135) Signed-off-by: Ting Sun <suntcrick@gmail.com> Co-authored-by: Xinyuan Tong <115166877+JustinTong0323@users.noreply.github.com>
…bound (sgl-project#41201) Co-authored-by: Xingyu Liu <38244988+charlotte12l@users.noreply.github.com>
…oject#41067) Co-authored-by: Mick Qian <mickqian@users.noreply.github.com>
…ailing V2 NextN draft (sgl-project#41194)
… shared expert, dense reduce_scatterv (sgl-project#41195)
…plete it in the next layer without the fused kernel (sgl-project#41196)
… the residency manager (sgl-project#34417) Co-authored-by: mickqian <mickqian@users.noreply.github.com>
CI does not install ComfyUI. Keep Qwen executors and the model patcher off the unit-test import path.
load_modules checks that flag, and this SimpleNamespace omitted it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sgl-project#35960 turns ComfyUI integrated mode into a DiT-only profile on the native pipeline (adapter + checkpoint spec). Flux / Z-Image / Qwen already sit on that path. MiniMax-H3 does not: it is a packed
[video, audio]DiT with T2V, I2VA, FL2VA, and R2V layouts that ComfyUI already ships as community graphs.This PR adds H3 to that same contract so ComfyUI keeps CLIP / VAE / the sampler loop, and SGLang runs one packed DiT forward per
apply_model.24GB skip-step speed-ups are not in this stack. They land in #35858 (Cache-DiT + layerwise) and #35684 (Spectrum). After those merge, a follow-up will expose the recommend recipes on
SGLDOptions.Modifications
[video, audio], translate ComfyUI layout / RoPE / denoise mask, match the official audio sigma-shift ODE.sampler.sample(); one SGLD generator per process (two-pass upscaler and back-to-back H3 graphs).MergedColumnper logical matrix.Workflows
ComfyUI R2V UI:
Shipped under
apps/ComfyUI_SGLDiffusion/workflows/:minimax_h3_t2v_sgld.jsonminimax_h3_r2v_sgld.jsonminimax_h3_t2v_sgld_upscaler.jsonAlso tested on this branch (H3 only):
ref2vacheckpoint)kitchen_int8+ layerwisesol_attn/sage_attnGGUF × LoRA is fail-closed. kitchen-int8 × LoRA is not. H3 SP needs
ulysses_degree=2.Tests
Unit:
test_comfyui_h3.py(layout vs ComfyUI, adapter, step kwargs, profile).4090 D 24GB · ComfyUI 0.30.0 · CLIP on CPU. Wall is prompt e2e.
Smoke (432×240 · 25f · 4 step) unless noted:
768P quality (1344×768 · 5s · 20 step · kitchen_int8 + FA + layerwise):
Test Video:
i2va_ramen_first.mp4
ref2va_girl.mp4
ref2va_video.mp4
CI States
Latest PR Test (Base): ❌ Missing
run-cilabel -- add it to run CI tests.Latest PR Test (Extra): ❌ Blocked --
run-ciis required first.Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.