Skip to content

[sgl-router] Fix readiness, IPv6 discovery, logging, and model validation - #40604

Merged
ShangmingCai merged 1 commit into
mainfrom
codex/router-readiness-startup
Sep 22, 2026
Merged

ShangmingCai merged 1 commit into
mainfrom
codex/router-readiness-startup

Conversation

@sherlockwu

@sherlockwu sherlockwu commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #40603. Merge #40603 first.

The router could report ready with no usable model pool, discover invalid IPv6 URLs, ignore logging flags, and return retryable 503s for unknown models.

Modifications

  • Require registered workers for the configured model, including both roles in PD mode; breaker state stays a per-request concern so readiness does not flap during cool-down.
  • Bracket IPv6 EndpointSlice addresses.
  • Initialize logging once from CLI settings before config resolution.
  • Validate the model before resolving its worker pool.

Accuracy Tests

cargo test --workspace --lib --tests --quiet and formatting checks passed. Added compact readiness, IPv6, and unknown-model regressions. Binary smoke checks confirmed JSON logs, CLI level filtering, and RUST_LOG precedence.

Speed Tests and Profiling

Not applicable; no inference changes.


CI States

Latest PR Test (Base): ✅ Run #35678134068
Latest PR Test (Extra): ❌ Run #35678133794
Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.

@sherlockwu
sherlockwu force-pushed the codex/router-readiness-startup branch from 3c7752e to 181d432 Compare September 21, 2026 17:23
@sherlockwu
sherlockwu changed the base branch from main to codex/router-cancelled-probes September 21, 2026 17:23
@sherlockwu
sherlockwu added this pull request to stack #40625 September 21, 2026 20:36
@sherlockwu sherlockwu added router run-ci CI: run the baseline test suite on this PR labels Sep 21, 2026
Base automatically changed from codex/router-cancelled-probes to main September 21, 2026 22:39
@sherlockwu
sherlockwu force-pushed the codex/router-readiness-startup branch from 181d432 to 13d6a91 Compare September 21, 2026 22:39
@sherlockwu
sherlockwu force-pushed the codex/router-readiness-startup branch from 13d6a91 to 74e179b Compare September 22, 2026 02:04

@ShangmingCai ShangmingCai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ShangmingCai
ShangmingCai merged commit 27f796c into main Sep 22, 2026
92 of 97 checks passed
@ShangmingCai
ShangmingCai deleted the codex/router-readiness-startup branch September 22, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

router run-ci CI: run the baseline test suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants