Skip to content

[Test] Set DP size in the mocked Metal profiler test - #40667

Merged
ch-wan merged 1 commit into
mainfrom
cheng/hot-fix/mlx-profiler-parallel-context
Sep 22, 2026
Merged

ch-wan merged 1 commit into
mainfrom
cheng/hot-fix/mlx-profiler-parallel-context

Conversation

@ch-wan

@ch-wan ch-wan commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

TestSchedulerProfilerManagerMPS.test_start_profile_success_with_mock_capture fails in _stop_profile() with ValueError: config namespace 'parallel' not published. #40339 changed the DP-width read from self.ps.dp_size to get_parallel().dp_size, but this model-free test only overrides TP rank, PP size, and MoE EP size and never publishes a runtime configuration.

The MLX CI failure on #40638 also reproduces on unmodified main at 15eba3b4643c126ab83e59af3c808b6811075817; the test and failing production path are identical there.

Modifications

Add dp_size=1 to the existing scoped parallel override in the mocked capture test. This is a one-line test-fixture fix; production code is unchanged.

Accuracy Tests

Native Apple Silicon, Python 3.11.16, PyTorch 2.13.0, MLX 0.32.2, with SGLANG_USE_MLX=1 and HF_HUB_OFFLINE=1:

  • Before: test_metal_profiler.py runs 10 tests and fails with the same unpublished-parallel error.
  • After: all 10 tests pass.
  • Pre-commit checks, including registered-test validation, pass.

Speed Tests and Profiling

Not applicable; test-only change.


CI States

Latest PR Test (Base): 🚫 Run #35680398058
Latest PR Test (Extra): ❌ Run #35680397770
Latest PR Test (AMD ROCm 10): 🚫 Run #35680397847

@ch-wan

ch-wan commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@github-actions github-actions Bot added the run-ci CI: run the baseline test suite on this PR label Sep 22, 2026
@ch-wan
ch-wan merged commit 1d02549 into main Sep 22, 2026
146 of 195 checks passed
@ch-wan
ch-wan deleted the cheng/hot-fix/mlx-profiler-parallel-context branch September 22, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apple-silicon run-ci CI: run the baseline test suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant