Changelog

[ewels]

This PR should fail due to the branch protection test.

However, what will be interesting is whether it will get an automated comment telling me that. The PR comes from a fork so previously this would not work, but if nf-core/tools#765 has worked as intended it should now work.

[github-actions]

Hi @,

It looks like this pull-request is has been made against the master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

[maxulysse]

Hi @,

This part is weird, why is there not your username?

[ewels]

Hi @,

This part is weird, why is there not your username?

Good spot! Apparently ${{ github.event.pull_request_target.user.login }} doesn't work, this will be a difference between the two event payloads (something I wanted to check with this PR).

Looking at https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#pull_request I guess that this is something that they changed. Docs says sender but the code example says user (so probably not updated the example).

I'll try with sender and see if that fixes it. Change in this PR, will merge and make a new PR.

[drpatelh]

Sommmeeebboooodddyy is having fun with the new test pipeline 👀