Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pull_request_target event for branch protection CI #766

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 6, 2020

Closes #765

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from a team November 6, 2020 23:11
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #766 (4e7437a) into dev (3c8730c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #766   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files          13       13           
  Lines        2753     2753           
=======================================
  Hits         2286     2286           
  Misses        467      467           
Impacted Files Coverage Δ
nf_core/lint.py 91.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fb385...4e7437a. Read the comment docs.

Copy link
Member

@abhi18av abhi18av left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After going through the contents of #765 , I'm looking forward to see this in action!

@abhi18av abhi18av merged commit 123beeb into nf-core:dev Nov 10, 2020
@ewels ewels deleted the branch-protection-action branch November 10, 2020 15:50
@ewels
Copy link
Member Author

ewels commented Nov 10, 2020

Nice, it worked! nf-core/testpipeline#3

@ewels ewels mentioned this pull request Nov 10, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants