Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete main.nf #5

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Delete main.nf #5

merged 2 commits into from
Nov 10, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 10, 2020

Continuation of #2 and #3 - hopefully the branch protection comment looks good now.

I also tried pull_request_target for the CI lint tests. So that should run on that workflow now and post a comment. Question is whether it fails in the same way again. I guess not, as it's not running on the merged code for this event trigger. Let's see...

@github-actions
Copy link

Hi @,

It looks like this pull-request is has been made against the ewels/testpipeline master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the ewels/testpipeline dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@ewels
Copy link
Member Author

ewels commented Nov 10, 2020

Getting there! The other fields now show up such as the pipeline name. Username still absent, so I guess that the docs are wrong and it is user still and not sender. Reverted to user.

Also realised I changed the wrong workflow file for the linting, so updated that.

@ewels ewels merged commit 8288ba4 into nf-core:master Nov 10, 2020
@ewels ewels mentioned this pull request Nov 10, 2020
@ewels ewels deleted the fail-lint branch November 10, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant