Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #4

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Changelog #4

merged 2 commits into from
Nov 10, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 10, 2020

Continuation of testing from #3 - let's see if we get my username in the comment this time!

@github-actions
Copy link

Hi @,

It looks like this pull-request is has been made against the master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@ewels
Copy link
Member Author

ewels commented Nov 10, 2020

Pants, didn't work :(

@ewels
Copy link
Member Author

ewels commented Nov 10, 2020

ahhh, ok the event payload is still called pull_request even though the trigger is now pull_request_target. Ok hopefully this should work now.

@ewels ewels merged commit 6c71803 into nf-core:master Nov 10, 2020
@ewels ewels deleted the minor-change-2 branch November 10, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant