Modifies since_value's validation to match rest API's requirements #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
…eYson/terraform-provider-newrelic into bug/since-value-validation
ghost
reviewed
Jun 7, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
added 3 commits
June 7, 2019 13:17
paultyng
approved these changes
Jul 10, 2019
Closed
kidk
pushed a commit
to aminoz007/terraform-provider-newrelic
that referenced
this pull request
Oct 12, 2021
…ation Modifies since_value's validation to match rest API's requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The rest API asserts that
since_valueisthe timeframe (in minutes) in which to evaluate the specified NRQL query. since_value must be between 1 and 20.However, the provider does not allow the number to be above
5.New Relic Documentation
nrql[since_value]https://docs.newrelic.com/docs/alerts/rest-api-alerts/new-relic-alerts-rest-api/alerts-conditions-api-field-namesFor @SuperBadCode who said he needs it.
Found out after the fact that it resolves #131
Rationale for custom ValidateFunc
It appears as though the newrelic API expects since_value to be a
stringinstead of anintwhich prevents the use of validate.IntBetween