Relax NRQL condition limitations #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* API allows durations between 1 and 20 * Previously limited durations to be between 1 and 5
* API allows any positive integer * Previously limited to 1, 2, 3, 4, 5, 10, 15, 30, 60, or 120
ghost
added
ghost
reviewed
May 10, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
* Validation method should not be exported out of package
|
Awesome, this addresses #131 |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NRQL condition limitations for
durationandsince_valueterms are previously overly strict and limiting out values that were perfectly acceptable for the API.durationis previously limiting to one of 1, 2, 3, 4, 5, 10, 15, 30, 60, or 120, but the API has no such restriction and only requires that it is a positive integersince_valueis limited to "1", "2", "3", "4", or "5", but the API allows any value between 1 and 20.This PR relaxes limitations on the term validation to more accurately reflect the limitations imposed by the API.