Merge some more PRs #153
Closed
Merge some more PRs #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NRQL alert conditions have 3 different types: static, outlier and baseline. 'static' is the default type, while 'baseline' is not yet supported by the REST API. The 'outlier' type requires two additional fields: 'expected_groups' (an integer) and 'ignore_overlap' (a boolean).
The API response for the creation of an AlertNrqlCondition with a type other than the default (static), such as an outlier condition, does not contain the `value_function` JSON field, and thus the struct's `ValueFunction` is set to the default string value (i.e. an empty string). That discrepancy creates a (virtual) difference between the plan and the state which can never be resolved, and thus `terraform apply` would seem to fail despite the changes being correctly applied. The approach taken here is setting default values for absent fields when they're absent from the response, which maintains backward compatibility with existing plans. An alternative approach where the default value was removed from the field definition in AlertNrqlCondition was also considered but discarded because it created a breaking change.
* API allows any positive integer * Previously limited to 1, 2, 3, 4, 5, 10, 15, 30, 60, or 120
ghost
added
|
Any updates on merging this one? I'd love to use outlier NRQL conditions |
jamesgoodhouse
suggested changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #136, #141, and dependency updates.