Support for newrelic_nrql_ alert_condition "since_value" values greater than 5

[timonwalkley]

newrelic_nrql_ alert_condition validation for the "since_value" attribute accepts values between 1-5. This attribute (now) supports values up to 20.

This attribute controls the evaluation offset of the nrql alert condition.

Terraform Version

Terraform v0.11.13
provider.newrelic v1.5.0

Affected Resource(s)

• newrelic_nrql_ alert_condition

Terraform Configuration Files

An example of a resource where this happens:

resource "newrelic_nrql_alert_condition" "test" {
  policy_id   = "${newrelic_alert_policy.warning_policy.id}"
  name        = "test"

  term {
    duration      = 5
    threshold     = 0
    priority      = "critical"
    operator      = "above"
    time_function = "any"
  }

  nrql {
    query       = "SELECT sum(provider.errors.Maximum) from ServerlessSample FACET provider.functionName"
    since_value = "15"
  }
}

Expected Behavior

Terraform Plan should succeed

Actual Behavior

Terraform Plan fails:
newrelic_nrql_alert_condition.lambda_error_warning: expected nrql.0.since_value to be one of [1 2 3 4 5], got 15

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply

Important Factoids

Are there anything atypical about your accounts that we should know? For example: Running in EC2 Classic? Custom version of OpenStack? Tight ACLs?

References

Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example:

• fix(deps): update module github.com/golangci/golangci-lint to v1.37.1 (master) #1234

[timonwalkley]

Can we just remove the validation? Happy to raise a PR.