Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Catalog Nit Nit list #2 #1405

Closed
9 tasks done
jpvajda opened this issue Jun 14, 2021 · 3 comments
Closed
9 tasks done

Public Catalog Nit Nit list #2 #1405

jpvajda opened this issue Jun 14, 2021 · 3 comments
Assignees
Labels
bug Something isn't working o11y public library o11y

Comments

@jpvajda
Copy link
Contributor

jpvajda commented Jun 14, 2021

This is a collection of nits to fix in the public catalog. This list 2 of our nits. :D

Nits

Need new tickets and design input from @danielgolden

  • add a back button on the olly pack details page so a user can get back to the grid view
  • change the display of dashboard images as they are really small in the gallery view @roadlittledawn has an idea for this and will make a #PR
  • Confirm if the Gallery component still works for how we display dashboard images, as if they are small they don't really offer much value
  • The fading image approach doesn't seem to work now that we implemented can we take that out?
  • Default (varies by browser) select styling for tab items for mobile (screenshot is iOS firefox) is a little weird (see screenshot in comment) Default (varies by browser) select styling for tab items for mobile is displaying poorly #1421
@jpvajda jpvajda added o11y o11y public library bug Something isn't working labels Jun 14, 2021
@jpvajda jpvajda added this to the [DevEn] Sprint 6 milestone Jun 14, 2021
@jpvajda jpvajda removed this from the [DevEn] Sprint 6 milestone Jun 14, 2021
@roadlittledawn roadlittledawn self-assigned this Jun 17, 2021
@jpvajda jpvajda self-assigned this Jun 17, 2021
@jpvajda jpvajda added this to the [DevEn] Sprint 7 milestone Jun 17, 2021
@roadlittledawn
Copy link
Contributor

roadlittledawn commented Jun 17, 2021

o11y pack detail page screenshot (iPhone X Firefox)

IMG_8D7008DEA995-1

@zstix
Copy link
Contributor

zstix commented Jun 21, 2021

The nav item for Observability packs should be highlighted when on a pack details page

This would require a (somewhat significant) change to the way that the theme renders "active" navigation links. At the moment, the navigation item that's highlighted is the current page. If we wanted, we could add the packs as their own navigation items in the nav, but I don't think that would scale well.

I think we should leave this as is. If we changed it as suggested, we would run the risk of the user thinking that they're on the observability pack page and they might not realize that they can click on that link to get back. For every other page on the developer site, if a page is highlight in the nav, it's the current page and clicking it again wont do anything.

@jpvajda
Copy link
Contributor Author

jpvajda commented Jun 21, 2021

We are reviewing the UI feedback under the Needs New ticket section above with @danielgolden this week, once we have confirmation how to proceed I can make the necessary tickets for implementation. Moving to Sprint 7 as this ticket will carry over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working o11y public library o11y
Projects
None yet
Development

No branches or pull requests

3 participants