Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove right fade on right when scrolled to end of gallery #1410

Closed

Conversation

roadlittledawn
Copy link
Contributor

Description

Removes the gradient fade on the right of image gallery when gallery is scrolled all the way to the end.

Related Issue(s) / Ticket(s)

Addresses part of #1405

Screenshot(s)

2021-06-16_17-42-31.mp4
2021-06-16_17-44-40.mp4

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 17, 2021

Gatsby Cloud Build Report

developer-website-feature/o11y-packs

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

@jpvajda
Copy link
Contributor

jpvajda commented Jun 23, 2021

@roadlittledawn any concern with merging this change in? I noticed it's a 6 day old pr.

@jpvajda jpvajda self-requested a review June 23, 2021 00:51
Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, functions well in the UI 😄

@zstix
Copy link
Contributor

zstix commented Jun 23, 2021

We're going to remove this in favor of the animated slider work done in #1417

@zstix zstix closed this Jun 23, 2021
@jpvajda jpvajda deleted the clang/remove-right-fade-last-img branch December 16, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants