-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animated image slider #1417
Merged
LizBaker
merged 21 commits into
feature/o11y-packs
from
clang/image-slider-simple-animate
Jun 23, 2021
Merged
Add animated image slider #1417
LizBaker
merged 21 commits into
feature/o11y-packs
from
clang/image-slider-simple-animate
Jun 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arrow if more than one image
…enshots. simplify styling of arrows
…arge screens to avoid squished images
… image on mobile screens
Gatsby Cloud Build Reportdeveloper-website-feature/o11y-packs 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m |
LizBaker
previously approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3 tasks
closing/reopening to retrigger gatsby preview |
LizBaker
approved these changes
Jun 23, 2021
3 tasks
🎉 This PR is included in version 1.57.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds animated image slider and nav controls to go to next/prev/specific slides. Does not show nav controls if only one image. Assumes for now there will always be at least one image passed in via props.
Wasn't sure what looked best for images either clipped on smaller screen or scaled down. Went with what I thought was slightly better option and scaled down image so you can see entire thing instead of tiny portion of it ¯_(ツ)_/¯
Tried to address styling for nav controls being visible but obtrusive on both dark / light screenshots.
Related Issue(s) / Ticket(s)
Related to:
#2
#1405Screenshot(s)
2021-06-22_09-57-45.mp4