Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animated image slider #1417

Merged
merged 21 commits into from
Jun 23, 2021

Conversation

roadlittledawn
Copy link
Contributor

Description

Adds animated image slider and nav controls to go to next/prev/specific slides. Does not show nav controls if only one image. Assumes for now there will always be at least one image passed in via props.

Wasn't sure what looked best for images either clipped on smaller screen or scaled down. Went with what I thought was slightly better option and scaled down image so you can see entire thing instead of tiny portion of it ¯_(ツ)_/¯

Tried to address styling for nav controls being visible but obtrusive on both dark / light screenshots.

Related Issue(s) / Ticket(s)

Related to:

Screenshot(s)

2021-06-22_09-57-45.mp4

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 22, 2021

Gatsby Cloud Build Report

developer-website-feature/o11y-packs

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 2m

@roadlittledawn roadlittledawn changed the title Clang/image slider simple animate Add animated image slider Jun 22, 2021
LizBaker
LizBaker previously approved these changes Jun 22, 2021
Copy link
Contributor

@LizBaker LizBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LizBaker
Copy link
Contributor

closing/reopening to retrigger gatsby preview

@LizBaker LizBaker closed this Jun 23, 2021
@LizBaker LizBaker reopened this Jun 23, 2021
@LizBaker LizBaker merged commit 651e660 into feature/o11y-packs Jun 23, 2021
@LizBaker LizBaker deleted the clang/image-slider-simple-animate branch June 23, 2021 22:12
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a Arrow button to move through the gallery so it's clear this is gallery component
3 participants