-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fade to image gallery #1395
Conversation
Gatsby Cloud Build Reportdeveloper-website-feature/o11y-packs 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m |
I provided the following ux feedback to @LizBaker in slack, also adding here.
4 I think the fade on the last image should not be present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my last comment for suggestions...
@jpvajda fixed the click-ability issue and reduced the fade. I couldn't reproduce the issue in firefox but that may be something that was fixed by fixing the click through. I also didn't come up with a good solution for getting rid of the fade at the end of the scroll so maybe we can make a separate ticket for that? |
@LizBaker Thanks for working on this I still feel the light-mode fade is a little Why don't we merge this in and I'll file a Nit to make the fade better on light mode, and also try to remove the fade on the last image. |
changes addressed or added to nit list
🎉 This PR is included in version 1.57.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This adds a fade to the right side of the image gallery to suggest there is more to scroll. I'm not sure if we want to add animation and get rid of the fade when you reach the last image 🤷♀️ but here's a first pass 🎉
Related Issue(s) / Ticket(s)
Closes #1385
Screenshot(s)