Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fade to image gallery #1395

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Add fade to image gallery #1395

merged 3 commits into from
Jun 15, 2021

Conversation

LizBaker
Copy link
Contributor

Description

This adds a fade to the right side of the image gallery to suggest there is more to scroll. I'm not sure if we want to add animation and get rid of the fade when you reach the last image 🤷‍♀️ but here's a first pass 🎉

Related Issue(s) / Ticket(s)

Closes #1385

Screenshot(s)

Screen Shot 2021-06-09 at 5 51 29 PM

Screen Shot 2021-06-09 at 5 51 41 PM

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 10, 2021

Gatsby Cloud Build Report

developer-website-feature/o11y-packs

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 2m

@LizBaker LizBaker linked an issue Jun 10, 2021 that may be closed by this pull request
1 task
aswanson-nr
aswanson-nr previously approved these changes Jun 10, 2021
@jpvajda
Copy link
Contributor

jpvajda commented Jun 10, 2021

I provided the following ux feedback to @LizBaker in slack, also adding here.

  1. in Firefox, once the scroll bar disappears you can't scroll the gallery, though in chrome this isn't an issue

  2. in light mode the fade is pretty intense

  3. I think each image should be clickable and open the image in a new tab so people can view it at a larger scale., --> might be a bug in css

4 I think the fade on the last image should not be present

@jpvajda jpvajda self-requested a review June 10, 2021 22:41
Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my last comment for suggestions...

@LizBaker
Copy link
Contributor Author

@jpvajda fixed the click-ability issue and reduced the fade. I couldn't reproduce the issue in firefox but that may be something that was fixed by fixing the click through. I also didn't come up with a good solution for getting rid of the fade at the end of the scroll so maybe we can make a separate ticket for that?

@jpvajda
Copy link
Contributor

jpvajda commented Jun 14, 2021

@LizBaker Thanks for working on this I still feel the light-mode fade is a little rough, but I know CSS can take hours to get something like this right. 🤣

Why don't we merge this in and I'll file a Nit to make the fade better on light mode, and also try to remove the fade on the last image.

@jpvajda jpvajda mentioned this pull request Jun 14, 2021
9 tasks
@LizBaker LizBaker dismissed jpvajda’s stale review June 15, 2021 16:18

changes addressed or added to nit list

@LizBaker LizBaker merged commit 4032c08 into feature/o11y-packs Jun 15, 2021
@LizBaker LizBaker deleted the liz/gallery-fade branch June 15, 2021 16:19
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fade the gallery image on the right hand side
4 participants