Add direct-consumers flag to jsz monitoring endpoint#7543
Merged
neilalexander merged 1 commit intomainfrom Nov 11, 2025
Merged
Conversation
Signed-off-by: Neil Twigg <neil@nats.io>
ripienaar
reviewed
Nov 11, 2025
| Accounts bool `json:"accounts,omitempty"` | ||
| Streams bool `json:"streams,omitempty"` | ||
| Consumer bool `json:"consumer,omitempty"` | ||
| DirectConsumer bool `json:"direct_consumer,omitempty"` |
Contributor
There was a problem hiding this comment.
why a new field and not just include them in the results? They'd have Direct:true set?
Member
Author
There was a problem hiding this comment.
I think only if you have ?config=true set, otherwise you can't tell them apart.
Contributor
There was a problem hiding this comment.
ah, yeah good call though unforunate but suppose best we can do for now
This was referenced Nov 11, 2025
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2025
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2025
Member
|
@neilalexander should we include that in jsz as well, to include in |
Member
|
oh, nevermind, it is there: nats-io/jsm.go#737 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently not possible to see direct consumers that are used by sources or mirrors. This extends
jszto make it possible to see these direct consumers to help when diagnosing sourcing/mirroring issues.Signed-off-by: Neil Twigg neil@nats.io