Fix logical race on shutting down clustered JetStream#7536
Merged
neilalexander merged 1 commit intomainfrom Nov 10, 2025
Merged
Fix logical race on shutting down clustered JetStream#7536neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Multiple goroutines listen to `js.clusterQuitC()`, so when `shutdownJetStream()` sent a message into the `qch`, it could have been picked up by other goroutines instead of `monitorCluster()`. Instead, close the channel and wait for completion on a second channel. Signed-off-by: Neil Twigg <neil@nats.io>
This was referenced Nov 10, 2025
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2025
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple goroutines listen to
js.clusterQuitC(), so whenshutdownJetStream()sent a message into theqch, it could have been picked up by other goroutines instead ofmonitorCluster(). Instead, close the channel and wait for completion on a second channel.Signed-off-by: Neil Twigg neil@nats.io