Skip to content

[IMPROVED] Stream catchup shows up in health check#7535

Merged
neilalexander merged 1 commit intomainfrom
maurice/catchup-health
Nov 10, 2025
Merged

[IMPROVED] Stream catchup shows up in health check#7535
neilalexander merged 1 commit intomainfrom
maurice/catchup-health

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen commented Nov 10, 2025 •
edited
Loading

The health check would report group node unhealthy while a stream is catching up and would never reach the stream catching up path, as the Raft state will not advance until after the catchup completes. Change the ordering such that we can properly report the catching up state.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 10, 2025 12:31
@MauriceVanVeen
[IMPROVED] Stream catchup shows up in health check
a2c603c 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen changed the title [IMPROVED] Stream catchup doesn't fail health check [IMPROVED] Stream catchup shows up in health check Nov 10, 2025
sciascid
sciascid approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sciascid sciascid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neilalexander
neilalexander approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit ed5282f into main Nov 10, 2025
48 checks passed
@neilalexander neilalexander deleted the maurice/catchup-health branch November 10, 2025 13:33
This was referenced Nov 10, 2025
Merged
Merged
neilalexander added a commit that referenced this pull request Nov 12, 2025
@neilalexander
Cherry-picks for v2.11.11-RC.4 (#7541)
d4c2d56 
Includes the following:

- #7535
- #7536
- #7538
- #7539
- #7440
- #7543

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Nov 12, 2025
@neilalexander
Cherry-picks for v2.12.2-RC.4 (#7542)
d7a1919 
Includes the following:

- #7534
- #7535
- #7536
- #7537
- #7538
- #7539
- #7543
- #7456

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilalexander neilalexander neilalexander approved these changes

@sciascid sciascid sciascid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MauriceVanVeen @neilalexander @sciascid