Skip to content

Cherry-picks for v2.12.2-RC.4#7542

Merged
neilalexander merged 10 commits intorelease/v2.12.2from
backports/v2.12.2-RC.4
Nov 12, 2025
Merged

Cherry-picks for v2.12.2-RC.4#7542
neilalexander merged 10 commits intorelease/v2.12.2from
backports/v2.12.2-RC.4

Conversation

MauriceVanVeen and others added 7 commits November 10, 2025 15:16
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Multiple goroutines listen to `js.clusterQuitC()`, so when `shutdownJetStream()`
sent a message into the `qch`, it could have been picked up by other goroutines
instead of `monitorCluster()`. Instead, close the channel and wait for completion
on a second channel.

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
This avoids heap escapes, see minio/highwayhash#29.

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander marked this pull request as ready for review November 11, 2025 16:18
@neilalexander neilalexander requested a review from a team as a code owner November 11, 2025 16:18
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bruth and others added 2 commits November 12, 2025 09:41
Signed-off-by: Byron Ruth <byron@nats.io>
@neilalexander neilalexander merged commit d7a1919 into release/v2.12.2 Nov 12, 2025
89 of 92 checks passed
@neilalexander neilalexander deleted the backports/v2.12.2-RC.4 branch November 12, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants