Skip to content

[FIXED] Validate default_sentinel JWT is bearer#7074

Merged
neilalexander merged 1 commit intomainfrom
maurice/default-sentinel-bearer
Jul 21, 2025
Merged

[FIXED] Validate default_sentinel JWT is bearer#7074
neilalexander merged 1 commit intomainfrom
maurice/default-sentinel-bearer

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

Resolves #7073

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner July 17, 2025 11:38
@MauriceVanVeen MauriceVanVeen requested review from a team and aricart and removed request for a team July 17, 2025 11:38
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/default-sentinel-bearer branch from 55b11fe to 695c7fd Compare July 17, 2025 11:59
@neilalexander
Copy link
Copy Markdown
Member

@aricart Mind sanity-checking this please?

Copy link
Copy Markdown
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - only issue is we don't have a reload test (no server restart should be required if the sentinel is updated)

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/default-sentinel-bearer branch from 695c7fd to cd8623d Compare July 21, 2025 13:56
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 425a7e5 into main Jul 21, 2025
48 checks passed
@neilalexander neilalexander deleted the maurice/default-sentinel-bearer branch July 21, 2025 14:15
neilalexander added a commit that referenced this pull request Jul 25, 2025
Includes the following:

- #7031
- #7033
- #7034
- #7035
- #7036
- #7040
- #7043
- #7045
- #7047
- #7046
- #7050
- #7051
- #7052
- #7053
- #7061
- #7063
- #7064
- #7065
- #7066
- #7070
- #7072
- #7080
- #7026
- #6728
- #7074
- #7089
- #7095
- #7087
- #7094
- #7096
- #7099

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default_sentinel - auth callout - Non bearer JWT results in connection to eb assigned to $G

3 participants