[FIXED] Get header value with shared prefix#7065
Merged
neilalexander merged 1 commit intomainfrom Jul 15, 2025
Merged
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Member
derekcollison
left a comment
derekcollison
left a comment
There was a problem hiding this comment.
I still think it might be worth considering pulling in all headers to a pooled struct that has any header that the server may want to react against.
Member
|
I think that's a good idea, but suggest we tackle that separately. |
Member
|
I did not mean in this PR. |
neilalexander
added a commit
that referenced
this pull request
Jul 25, 2025
Includes the following: - #7031 - #7033 - #7034 - #7035 - #7036 - #7040 - #7043 - #7045 - #7047 - #7046 - #7050 - #7051 - #7052 - #7053 - #7061 - #7063 - #7064 - #7065 - #7066 - #7070 - #7072 - #7080 - #7026 - #6728 - #7074 - #7089 - #7095 - #7087 - #7094 - #7096 - #7099 Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Sep 16, 2025
The same issue that was fixed here: #7065, but now for removing the `Nats-Schedule-Target` and `Nats-Schedule` header for the delayed message. The latter header was not removed if the target header was defined first. This would prevent the delayed message from being scheduled. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nats-Expected-Last-Subject-Sequence-SubjectandNats-Expected-Last-Subject-Sequenceshare a common prefix. We could not get the proper value for the latter header depending on the ordering in the headers.Signed-off-by: Maurice van Veen github@mauricevanveen.com