Skip to content

[CHANGED] add endpoint names to monitoring overivew page#7066

Merged
neilalexander merged 1 commit intomainfrom
name_endpoints
Jul 16, 2025
Merged

[CHANGED] add endpoint names to monitoring overivew page#7066
neilalexander merged 1 commit intomainfrom
name_endpoints

Conversation

@alexbozhenko
Copy link
Copy Markdown
Member

People refer to monitoring endpoint names by the url. Add it for convenience.

image

Signed-off-by: Alex Bozhenko alexbozhenko@gmail.com

Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
@alexbozhenko alexbozhenko requested a review from a team as a code owner July 15, 2025 15:03
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 2359d0d into main Jul 16, 2025
69 of 70 checks passed
@neilalexander neilalexander deleted the name_endpoints branch July 16, 2025 09:43
@derekcollison
Copy link
Copy Markdown
Member

Why do we feel we need this?

@derekcollison
Copy link
Copy Markdown
Member

I prefer it left how it is. Trivial to hover over and figure out the url.

@alexbozhenko
Copy link
Copy Markdown
Member Author

alexbozhenko commented Jul 16, 2025

@derekcollison The motivation I had in mind is in PR description:

People refer to monitoring endpoint names by the url.

When on a call with a customer, we would say "let's check varz", and people would know what we meant.
We never say, e.g. "let's check "health probe" monitoring endpoint.

@derekcollison
Copy link
Copy Markdown
Member

I do not think adding it there does anything except make the UI more cluttered - which I prefer not to do - and you can get the URL trivially by hovering over the link.

neilalexander added a commit that referenced this pull request Jul 23, 2025
Follow-up to #7066

Still simplifies life of dummies who do not remember all the endpoints
by heart, but also makes UI not cluttered by showing endpoint only on
hover
<img width="300" height="500" alt="image"
src="https://github.com/user-attachments/assets/1668b499-5565-4150-a05d-fd1ff4f2749d"
/>



Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
@wallyqs wallyqs changed the title add endpoint names to monitoring overivew page [CHANGED] add endpoint names to monitoring overivew page Jul 24, 2025
neilalexander added a commit that referenced this pull request Jul 25, 2025
Includes the following:

- #7031
- #7033
- #7034
- #7035
- #7036
- #7040
- #7043
- #7045
- #7047
- #7046
- #7050
- #7051
- #7052
- #7053
- #7061
- #7063
- #7064
- #7065
- #7066
- #7070
- #7072
- #7080
- #7026
- #6728
- #7074
- #7089
- #7095
- #7087
- #7094
- #7096
- #7099

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants