Skip to content

[TEST] De-flake TestGatewayTLSMixedIPAndDNS#7050

Merged
neilalexander merged 1 commit intomainfrom
maurice/deflake-gateway
Jul 9, 2025
Merged

[TEST] De-flake TestGatewayTLSMixedIPAndDNS#7050
neilalexander merged 1 commit intomainfrom
maurice/deflake-gateway

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

The would flake (especially under CI) when the first gateway connection would fail. The reconnect would not be done because they are implicit gateway connections for this test, which don't retry unless configured. Configuring retries makes this test not flake anymore.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner July 9, 2025 14:34
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neilalexander neilalexander merged commit 3654a36 into main Jul 9, 2025
69 of 70 checks passed
@neilalexander neilalexander deleted the maurice/deflake-gateway branch July 9, 2025 14:54
@wallyqs wallyqs changed the title De-flake TestGatewayTLSMixedIPAndDNS [TEST] De-flake TestGatewayTLSMixedIPAndDNS Jul 24, 2025
neilalexander added a commit that referenced this pull request Jul 25, 2025
Includes the following:

- #7031
- #7033
- #7034
- #7035
- #7036
- #7040
- #7043
- #7045
- #7047
- #7046
- #7050
- #7051
- #7052
- #7053
- #7061
- #7063
- #7064
- #7065
- #7066
- #7070
- #7072
- #7080
- #7026
- #6728
- #7074
- #7089
- #7095
- #7087
- #7094
- #7096
- #7099

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants