[IMPROVED] Improvements to interest policy and workqueue clustered streams.#5270
Merged
derekcollison merged 1 commit intomainfrom Apr 3, 2024
Merged
[IMPROVED] Improvements to interest policy and workqueue clustered streams.#5270derekcollison merged 1 commit intomainfrom
derekcollison merged 1 commit intomainfrom
Conversation
yordis
reviewed
Apr 3, 2024
Specifically around interest and limited streams that are clustered. Since we operate consumers and streams independently, when a stream is removing msgs when acked and acks are coming into different servers at different times, etc. Messages can get stranded. We introduce a better check of the interest state based on a collective low ack floor that will purge our copy of the stream to catch up. We run this periodically in monitorStream and during certain conditions. Thanks to Wally for introducing the test that stresses this part of the system. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
wq-updates
branch
from
02e59c8 to
b6ff2ef
Compare
This was referenced Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically around interest and limited streams that are clustered. Since we operate consumers and streams independently, when a stream is removing msgs when acked and acks are coming into different servers at different times, etc. Messages can get stranded.
We introduce a better check of the interest state based on a collective low ack floor that will purge our copy of the stream to catch up. We run this periodically in monitorStream and during certain conditions.
Thanks to Wally for introducing the test that stresses this part of the system.
Signed-off-by: Derek Collison derek@nats.io