Tweak clone behaviour of User and NkeyUser#5246
Merged
derekcollison merged 1 commit intomainfrom Mar 26, 2024
Merged
Conversation
In this case, an empty-but-non-nil map would not be copied, which could result in the clone referring to the original map. Also implement a deep copy of `AllowedConnectionTypes` for `NkeyUser`, like `User` already has. Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case, an empty-but-non-nil map would not be copied, which could result in the clone referring to the original map.
Also implement a deep copy of
AllowedConnectionTypesforNkeyUser, likeUseralready has.Reported-by: Trail of Bits https://www.trailofbits.com
Signed-off-by: Neil Twigg neil@nats.io