Constant-time evaluation of non-bcrypt passwords#5247
Merged
derekcollison merged 1 commit intomainfrom Mar 26, 2024
Merged
Conversation
Signed-off-by: Neil Twigg <neil@nats.io>
| // turning a string into []byte normally. | ||
| spass := stringToBytes(serverPassword) | ||
| cpass := stringToBytes(clientPassword) | ||
| if subtle.ConstantTimeCompare(spass, cpass) == 0 { |
Member
There was a problem hiding this comment.
So this will slow down reconnect yes?
Member
Author
There was a problem hiding this comment.
Should be marginal, standard string comparison will give up on the first mismatching character, whereas ConstantTimeCompare iterates over all characters before returning (unless they're different lengths, in which case it gives up immediately).
Member
There was a problem hiding this comment.
Should be about no difference in time for valid credentials. Should only make invalid credential rejection slower.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that comparison of non-bcrypted passwords is done in constant time, whereas otherwise timing information may be apparent on a network with next to no jitter.
Reported-by: Trail of Bits https://www.trailofbits.com
Signed-off-by: Neil Twigg neil@nats.io