Adds tests for WQ stream sourcing with limit and discard new behavior#5112
Merged
derekcollison merged 1 commit intomainfrom Mar 26, 2024
Merged
Adds tests for WQ stream sourcing with limit and discard new behavior#5112derekcollison merged 1 commit intomainfrom
derekcollison merged 1 commit intomainfrom
Conversation
Member
neilalexander
left a comment
neilalexander
left a comment
There was a problem hiding this comment.
Minor stylistic things but otherwise looks OK to me.
Contributor
Author
|
Requested changes were done. Is it good now? |
jnmoyne
force-pushed
the
jnm/sourcing_wq_limit_tests
branch
3 times, most recently
from
66cc368 to
a30c818
Compare
neilalexander
approved these changes
Mar 25, 2024
Member
neilalexander
left a comment
neilalexander
left a comment
There was a problem hiding this comment.
Couple of the if err != nil { require_NoError(...) } in TestJetStreamSourceWorkingQueueWithLimit are superfluous but not actually harmful, otherwise LGTM.
…r stream and has a max messages limit and has discard policy new. The stream should never go over the limit but should still get all the messages in the stream being sourced (i.e. getting more messages as they are consumed from the WQ stream) Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
jnmoyne
force-pushed
the
jnm/sourcing_wq_limit_tests
branch
from
1e25feb to
470dbda
Compare
Contributor
Author
|
Cleaned up the other test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to check the existing behavior: when creating a WQ stream that sources from another stream and has a max messages limit and has discard policy new. The stream should never go over the limit but should still get all the messages in the stream being sourced (i.e. getting more messages as they are consumed from the WQ stream).