osal Integration candidate: 2021-02-23 #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 26, 2021
Bumps to: - cFE v6.8.0-rc1+dev365 - osal v5.2.0-rc1+dev280 - cFS-GroundSystem v2.2.0-rc1+dev29 See: - nasa/osal#830 - nasa/cFE#1171 - nasa/cFS-GroundSystem#162 Includes: - nasa/cFE#1148 - nasa/cFE#1168 - nasa/cFE#1158 - nasa/cFE#1151 - nasa/cFE#1173 - nasa/osal#794 - nasa/osal#818 - nasa/osal#820 - nasa/osal#815 - nasa/osal#813 - nasa/osal#822 - nasa/osal#823 - nasa/cFS-GroundSystem#156
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
The version number macros major, minor, and revision, are used in the HK telemetry which can lead to confusion.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
The version number macros major, minor, and revision, are used in the HK telemetry which can lead to confusion.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#830, Set Revision to 99 for development build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #798 and #799, tests fail when no network
Fix #814, UT Stub match macro behavior
Fix #819, Remove redundant logic
Fix #817, Simplify name truncation in OS_CreateSocketName
Fix #779, Change global vars to not be hidden by local vars.
Fix #770, Remove deprecated elements
Fix #737, UT_Stub_CheckForceFail -> UT_Stub_CheckDefaultReturnValue
Testing performed
See https://github.com/nasa/cFS/pull/193/checks
Expected behavior changes
PR #813 - Makes tests skip after getting their first not implemented error.
PR #815 - Updates stub helpers to match the behavior of calling the default implementation stub macro (NULL VA list)
PR #820 - Removes redundant logic and assignment to fix static analysis warnings
PR #818 - Truncates at the end of the logic flow for socket name as opposed to possibly 3 different locations. Fixes static analysis warning.
PR #794 - Renames
timer_idin unit tests tolocal_timer_idto avoid conflictsPR #822 - Removes all deprecated elements
PR #823 - No behavior change. Renames
UT_Stub_CheckForceFailtoUT_Stub_CheckDefaultReturnValue, also only setsValueif notNULL(can pass in NULL value doesn't matter)System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#193
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@zanzaben
@skliper