Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select-test fails if network isn't included #798

Closed
skliper opened this issue Feb 10, 2021 · 0 comments · Fixed by #813 or #830
Closed

select-test fails if network isn't included #798

skliper opened this issue Feb 10, 2021 · 0 comments · Fixed by #813 or #830
Assignees
@zanzaben
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Feb 10, 2021

Is your feature request related to a problem? Please describe.
select-test hung when run with all the include options being false, suspect it's due to OSAL_CONFIG_INCLUDE_NETWORK

Describe the solution you'd like
Select test should handle either configuration (check for OS_ERR_NOT_IMPLEMENTED and skip tests that don't apply)

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added unit-test Tickets related to the OSAL unit testing (functional and/or coverage) and removed enhancement labels Feb 10, 2021
@skliper skliper added this to the 6.0.0 milestone Feb 10, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Feb 16, 2021
@zanzaben
Fix nasa#798, select test skips when network is not implemented.
709dd41
@zanzaben zanzaben mentioned this issue Feb 16, 2021
Merged
@skliper skliper linked a pull request Feb 17, 2021 that will close this issue
Fix #798 and #799, tests fail when no network #813
Merged
@astrogeco astrogeco added the bug label Feb 24, 2021
astrogeco added a commit that referenced this issue Feb 24, 2021
@astrogeco
Merge pull request #813 from zanzaben/Fix_798_tests_fail_when_no_network
ff499f1 
Fix #798 and #799, tests fail when no network
@astrogeco astrogeco mentioned this issue Feb 24, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#798, Remove OS_Milli2Ticks document reference (deprecated)
b900c36
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#799 from skliper/fix798-milli2ticks-dep
73316ed 
Fix nasa#798, Remove OS_Milli2Ticks document reference (deprecated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
3 participants
@zanzaben @skliper @astrogeco