Fix #155, Remove unnecessary type translations #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JackNWhite - could you confirm if this solves your issue (#155)? |
skliper
added
the
CCB:Ready
|
My apologies, but it doesn't fully work. Now, if the type is |
|
It should! I'll fix that. Thanks for checking. |
skliper
force-pushed
the
fix155-param_translation
branch
from
7d37c0a
to
c8766bc
Compare
|
CCB:2021-02-17 APPROVED
|
|
This pull request introduces 1 alert when merging c8766bc into f0dfdbd - view on LGTM.com new alerts:
|
astrogeco
removed
the
CCB:Ready
skliper
force-pushed
the
fix155-param_translation
branch
from
c8766bc
to
4dcee36
Compare
skliper
force-pushed
the
fix155-param_translation
branch
from
4dcee36
to
2333fb8
Compare
|
@JackNWhite OK, was able to spot check this update... hopefully it works for you? |
|
I spot-checked and it worked for me, so as far as I know this is good to go. |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 26, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 26, 2021
Bumps to: - cFE v6.8.0-rc1+dev365 - osal v5.2.0-rc1+dev280 - cFS-GroundSystem v2.2.0-rc1+dev29 See: - nasa/osal#830 - nasa/cFE#1171 - nasa/cFS-GroundSystem#162 Includes: - nasa/cFE#1148 - nasa/cFE#1168 - nasa/cFE#1158 - nasa/cFE#1151 - nasa/cFE#1173 - nasa/osal#794 - nasa/osal#818 - nasa/osal#820 - nasa/osal#815 - nasa/osal#813 - nasa/osal#822 - nasa/osal#823 - nasa/cFS-GroundSystem#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #155 - removes unnecessary type translations from CHeaderParser.py (also removes broken "double")
Testing performed
Requesting test by @JackNWhite
Spot checked processing of int32's so at least the pattern is ok (and runs)
Expected behavior changes
uint64will no longer get translated byCHeaderParserinto the unsupporteddoubletypeSystem(s) tested on
cFS Dev Server, Ubuntu 18.04
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC