Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #798 and #799, tests fail when no network #813

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #798
Fixes #799
made the tests skip after getting their first not implemented error.

Testing performed
Build and run unit test

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 16, 2021
@skliper
Copy link
Contributor

skliper commented Feb 16, 2021

See also #752, specifically "Utilize UTASSERT_CASETYPE_NA to report all OS_ERR_NOT_IMPLEMENTED returns."

Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report OS_ERR_NOT_IMPLEMENTED via UTASSERT_CASETYPE_NA.

@astrogeco
Copy link
Contributor

CCB 2021-02-17 APPROVED, squash "752" commit

@zanzaben zanzaben force-pushed the Fix_798_tests_fail_when_no_network branch from c7f6093 to 96fa1f9 Compare February 17, 2021 17:24
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 17, 2021
@astrogeco astrogeco changed the title Fix #798 #799, tests fail when no network Fix #798 and #799, tests fail when no network Feb 24, 2021
@astrogeco astrogeco merged commit ff499f1 into nasa:integration-candidate Feb 24, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 24, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 26, 2021
@zanzaben zanzaben deleted the Fix_798_tests_fail_when_no_network branch April 2, 2021 14:10
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey added a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Add tests for the following APIs:

CFE_ES_RegisterGenCounter
CFE_ES_CounterID_ToIndex
CFE_ES_GetGenCounterIDByName
CFE_ES_GetGenCounterName
CFE_ES_GetGenCount
CFE_ES_SetGenCount
CFE_ES_IncrementGenCounter
CFE_ES_DeleteGenCounter
jphickey added a commit to jphickey/osal that referenced this pull request Aug 10, 2022
At UtPrintf statements to indicate the APIs that the test
is focused on.
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network-api-test fails if OSAL_CONFIG_INCLUDE_NETWORK is false select-test fails if network isn't included
3 participants