Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lgtm.yml to exclude Ui files #92

Closed
lbleier-GSFC opened this issue May 27, 2020 · 2 comments · Fixed by #94, #96 or #118
Closed

Update lgtm.yml to exclude Ui files #92

lbleier-GSFC opened this issue May 27, 2020 · 2 comments · Fixed by #94, #96 or #118
Assignees
@lbleier-GSFC

Comments

@lbleier-GSFC
Copy link
Contributor

lbleier-GSFC commented May 27, 2020 •
edited
Loading

Describe the bug
The auto-generated .py files created by pyuic5 should not be analyzed by lgtm

Expected behavior
Do not have lgtm analysis include files starting with Ui_

Additional context
This is specifically related to nasa/cFS-GroundSystem#46

Reporter Info
Leor Bleier, NASA GSFC\Code 582
@lbleier-GSFC lbleier-GSFC self-assigned this May 27, 2020
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 27, 2020
@lbleier-GSFC
Fix nasa#46 Recommended lgtm python issues
257f929 
Problems shown in this issue were fixed in nasa#72 as part of
updates/refactoring. Other lgtm issues addressed here.
Problems in auto-generated .py files not addressed.
Auto-generated .py files renamed with Ui_ prefix.
The lgtm.yml file must be updated to exclude these
See nasa/cFS#92
@lbleier-GSFC lbleier-GSFC mentioned this issue May 27, 2020
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS that referenced this issue May 29, 2020
@lbleier-GSFC
Fix nasa#92 - Update lgtm.yml to exclude Ui files
db52975
@lbleier-GSFC lbleier-GSFC mentioned this issue May 29, 2020
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS that referenced this issue May 29, 2020
@lbleier-GSFC
Revert "Fix nasa#92 - Update lgtm.yml to exclude Ui files"
61912c1 
This reverts commit db52975.
lbleier-GSFC added a commit to lbleier-GSFC/cFS that referenced this issue May 29, 2020
@lbleier-GSFC
Fix nasa#92 - Update lgtm.yml file to exclude Ui files
b7e9fb8
@skliper skliper linked a pull request May 29, 2020 that will close this issue
Fix #92 - Update lgtm.yml to exclude Ui files #94
Merged
astrogeco added a commit that referenced this issue Jun 2, 2020
@astrogeco
Merge pull request #94 from lbleier-GSFC/fix92-updatelgtm
f6a6ef5 
Fix #92 - Update lgtm.yml to exclude Ui files
astrogeco pushed a commit that referenced this issue Jun 3, 2020
@lbleier-GSFC
Fix #92 - Update lgtm.yml file to exclude Ui files
c4cbe01
@astrogeco astrogeco mentioned this issue Jun 9, 2020
Merged
astrogeco added a commit that referenced this issue Jun 11, 2020
@astrogeco @lbleier-GSFC @skliper
Integration Candidate: 2020-05-27 (#96)
da695db 
* Fix #92 - Update lgtm.yml file to exclude Ui files

* Update sample_app to reflect HOTFIX

* Update cFS-GroundSystem to reflect HOTFIX

* Add osal PR#495 to fix race condition

* Update sample_app to reflect unit test HOTFIX

* Update submodules to master for IC-2020-05-27

Co-authored-by: lbleier-GSFC <[email protected]>
Co-authored-by: Jacob Hageman <[email protected]>
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 24, 2020
@lbleier-GSFC
Fix nasa#46 Recommended lgtm python issues
f52c69d 
Problems shown in this issue were fixed in nasa#72 as part of
updates/refactoring. Other lgtm issues addressed here.
Problems in auto-generated .py files not addressed.
Auto-generated .py files renamed with Ui_ prefix.
The lgtm.yml file must be updated to exclude these
See nasa/cFS#92
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Fix nasa#46 Recommended lgtm python issues
fb0ccb6 
Problems shown in this issue were fixed in nasa#72 as part of
updates/refactoring. Other lgtm issues addressed here.
Problems in auto-generated .py files not addressed.
Auto-generated .py files renamed with Ui_ prefix.
The lgtm.yml file must be updated to exclude these
See nasa/cFS#92
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Squashed commit of the following:
adf31d8 
commit 2a8911f
Author: Leor Bleier <[email protected]>
Date:   Fri Jun 26 17:34:54 2020 -0400

    Enhancement nasa#103 - updates to allow user to select header version

    Updates GUI and backend to allow user to select
    header version offsets, or custom byte offsets

commit 9d233eb
Author: Leor Bleier <[email protected]>
Date:   Thu Jun 25 17:12:31 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil and other files

commit 6d3f7ed
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 24 13:53:51 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit 8ad565c
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 24 10:56:45 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit a0d1872
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 23 15:39:25 2020 -0400

    WIP: Enhancement nasa#103 - Implemented native cmdUtil

    Native cmdUtil has only subset of full cmdUtil functionality
    Also implemented updates to GUI and backend to support custom
    byte offsets in tlm and cmd

commit 09261e5
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 16 13:27:26 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Fix for rebase merge error

commit 7754c9f
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 16 12:38:33 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Updated UI and backend to support custom header sizes.
    Change only impacts tlm currently

commit 821f06c
Author: Leor Bleier <[email protected]>
Date:   Mon Jun 1 09:57:02 2020 -0400

    Feature nasa#98 - Refactor UI to table widgets

    Removed unnecessary file

commit b0bd3fa
Author: Leor Bleier <[email protected]>
Date:   Mon Jun 1 09:06:45 2020 -0400

    Feature nasa#98 - Refactor UI to use table widgets

    Backend updated accordingly. Other various tweaks/fixes as needed

commit fb0ccb6
Author: Leor Bleier <[email protected]>
Date:   Wed May 27 16:23:40 2020 -0400

    Fix nasa#46 Recommended lgtm python issues

    Problems shown in this issue were fixed in nasa#72 as part of
    updates/refactoring. Other lgtm issues addressed here.
    Problems in auto-generated .py files not addressed.
    Auto-generated .py files renamed with Ui_ prefix.
    The lgtm.yml file must be updated to exclude these
    See nasa/cFS#92

commit b3d8039
Author: Leor Bleier <[email protected]>
Date:   Wed May 20 07:54:39 2020 -0400

    Fix nasa#88 - Modify GroundSystem to use JSON files generated by CCDD

    Also includes further updates and refinements to overall UI

commit 26486cb
Author: Leor Bleier <[email protected]>
Date:   Thu May 14 11:37:11 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Further edits based on CCB feedback, and other fixes as necessary

commit 876a39d
Author: Leor Bleier <[email protected]>
Date:   Mon May 11 17:08:21 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Includes code cleanup/refactoring. Also fixes nasa#71
skliper added a commit to skliper/cFS that referenced this issue Jul 27, 2020
@skliper
Fix nasa#92, LGTM exclude generated files
1e7861e
@skliper skliper reopened this Jul 27, 2020
@skliper
Copy link
Contributor

skliper commented Jul 27, 2020 •
edited
Loading

Wasn't actually solved by commits above (#94 didn't work).

@skliper skliper mentioned this issue Jul 27, 2020
Merged
@lbleier-GSFC
Copy link
Contributor Author

Wasn't actually solved by commits above (#94 didn't work).

I admit I don't fully understand how lgtm works with this file. The exclude line I added might simply be in the wrong place.

astrogeco added a commit that referenced this issue Aug 4, 2020
@astrogeco
Merge pull request #118 from skliper/fix92-lgtm-exclude-generated
5b787a5 
Fix #92, LGTM exclude generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbleier-GSFC lbleier-GSFC

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@skliper @lbleier-GSFC