Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyQt4 to PyQt5 #72

Closed
lbleier-GSFC opened this issue Apr 10, 2020 · 0 comments · Fixed by #85 or #90
Closed

Update PyQt4 to PyQt5 #72

lbleier-GSFC opened this issue Apr 10, 2020 · 0 comments · Fixed by #85 or #90
Assignees
@lbleier-GSFC
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@lbleier-GSFC
Copy link
Contributor

lbleier-GSFC commented Apr 10, 2020 •
edited
Loading

Describe the solution you'd like
All usage of PyQt4 should be updated to PyQt5

Additional context
PyQt4 is extremely old at this point, and unless there is a specific need, it should not be used

Note: This fix will include code cleanup/updates as necessary, as well as fix #71 and #79

Requester Info
Leor Bleier, NASA GSFC\Code 582
@lbleier-GSFC lbleier-GSFC added the enhancement New feature or request label Apr 10, 2020
@lbleier-GSFC lbleier-GSFC self-assigned this Apr 10, 2020
@skliper skliper added this to the 2.2.0 milestone Apr 10, 2020
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 17, 2020
@lbleier-GSFC
(WIP) Fix nasa#72, Upgrade PyQt including Python code cleanup
595a54e
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 21, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade to PyQt5 and fix/update/clean as needed
ac26d55
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 21, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and clean/fix/refactor for python3
beef5f4
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 22, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
acd0b85
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 23, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
47dd195
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 24, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
9ee31b6
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
7d50b49
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
(WIP) Fix nasa#72, Upgrade to PyQt5 and fix/update/clean as needed
8fb57f9
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade to PyQt5 and fix/update/clean as needed
a2d1432
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and clean/fix/refactor for python3
5135ea3
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
10f55fd
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
dd912cd
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
725e8fa
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
41f5f00
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 27, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
8f191ea
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
(WIP) Fix nasa#72, Upgrade to PyQt5 and fix/update/clean as needed
46a9696
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade to PyQt5 and fix/update/clean as needed
6aca213
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and clean/fix/refactor for python3
8db78cb
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
81a892b
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
76f7287
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
d8b5fc0
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
8daf705
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
WIP Fix nasa#72 - Upgrade PyQt and implement fixes/cleanup/refactoring
a990492
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Apr 29, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
dbc7ac3 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 1, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
b013c86 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 4, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
f05f03f 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 5, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
5faf1c1 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 7, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
1f897ef 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 7, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
a60cc54 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 7, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
49fc159 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 7, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5 and implement other fixes…
be45b09 
… as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 7, 2020
@lbleier-GSFC
(WIP) Fixes nasa#72, upgrade PyQt4 to PyQt5
ac9251f 
Implement other fixes as needed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 7, 2020
@lbleier-GSFC
Fixes nasa#72, upgrade PyQt4 to PyQt5
8a7df18 
Incorporated dmknutsen fixes from nasa#83. Also fixes nasa#71
This was referenced May 7, 2020
Open
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 11, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
9e95db1 
Includes code cleanup/refactoring. Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 11, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
9555ec8 
Includes code cleanup/refactoring. Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 14, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
2ff4767 
Further edits based on CCB feedback, and other fixes as necessary
@skliper skliper linked a pull request May 15, 2020 that will close this issue
Fix #72 and #71, Upgrades to PyQt 5 and sequence count fix #85
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 20, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
57f549d 
Squashed commit of the following:

commit 565ce6ee1cdb5837ee5dc1af1e7b931b79e10442
Author: Leor Bleier <[email protected]>
Date:   Thu May 14 11:37:11 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Further edits based on CCB feedback, and other fixes as necessary

commit e2376f7
Merge: 9555ec8 e8bd93c
Author: Leor Bleier <[email protected]>
Date:   Wed May 20 08:00:05 2020 -0400

    Merge branch 'integration-candidate' of https://github.com/nasa/cFS-GroundSystem into integration-candidate

commit e8bd93c
Author: Gerardo E. Cruz-Ortiz <[email protected]>
Date:   Wed May 13 11:06:28 2020 -0400

    Increase version to 2.1.8 in Guide-Ground System and update Readme.

commit 9555ec8
Author: Leor Bleier <[email protected]>
Date:   Mon May 11 17:08:21 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Includes code cleanup/refactoring. Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 20, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
5ae4d32 
Also includes general fixes/refactoring/cleanup. Also fixes nasa#71
astrogeco added a commit that referenced this issue May 20, 2020
@astrogeco
Merge pull request #85 from lbleier-GSFC/fix72-upgradepyqt
8cb6a28 
Fix #72 and #71, Upgrades to PyQt 5 and sequence count fix
@astrogeco astrogeco mentioned this issue May 20, 2020
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 27, 2020
@lbleier-GSFC
Fix nasa#46 Recommended lgtm python issues
257f929 
Problems shown in this issue were fixed in nasa#72 as part of
updates/refactoring. Other lgtm issues addressed here.
Problems in auto-generated .py files not addressed.
Auto-generated .py files renamed with Ui_ prefix.
The lgtm.yml file must be updated to exclude these
See nasa/cFS#92
@lbleier-GSFC lbleier-GSFC mentioned this issue May 27, 2020
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue May 29, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
931297a 
Further edits based on CCB feedback, and other fixes as necessary
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 17, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
f27b4d3 
Includes code cleanup/refactoring. Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 17, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
e70f94a 
Further edits based on CCB feedback, and other fixes as necessary
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 17, 2020
@lbleier-GSFC
Fix nasa#72 - Includes code cleanup/refactoring
ab90c9b 
Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 17, 2020
@lbleier-GSFC
Fix nasa#72 - Change pickle load based on CCB feedback
a4c9aae 
Other fixes as necessary
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 23, 2020
@lbleier-GSFC
Squashed commit of the following:
a68dcda 
commit 1eb8a5c
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 17 11:09:28 2020 -0400

    Feature nasa#98 - Refactor UI to use table widgets

    Backend updated accordingly. Other various tweaks/fixes as needed

commit b8017f1
Author: Leor Bleier <[email protected]>
Date:   Wed May 20 07:54:39 2020 -0400

    Fix nasa#88 - Modify GroundSystem to use JSON files generated by CCDD

    Also includes further updates and refinements to overall UI

commit a4c9aae
Author: Leor Bleier <[email protected]>
Date:   Thu May 14 11:37:11 2020 -0400

    Fix nasa#72 - Change pickle load based on CCB feedback

    Other fixes as necessary

commit ab90c9b
Author: Leor Bleier <[email protected]>
Date:   Mon May 11 17:08:21 2020 -0400

    Fix nasa#72 - Includes code cleanup/refactoring

    Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 24, 2020
@lbleier-GSFC
Fix nasa#46 Recommended lgtm python issues
f52c69d 
Problems shown in this issue were fixed in nasa#72 as part of
updates/refactoring. Other lgtm issues addressed here.
Problems in auto-generated .py files not addressed.
Auto-generated .py files renamed with Ui_ prefix.
The lgtm.yml file must be updated to exclude these
See nasa/cFS#92
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
876a39d 
Includes code cleanup/refactoring. Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Fix nasa#72 - Upgrade PyQt4 to PyQt5
26486cb 
Further edits based on CCB feedback, and other fixes as necessary
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Fix nasa#46 Recommended lgtm python issues
fb0ccb6 
Problems shown in this issue were fixed in nasa#72 as part of
updates/refactoring. Other lgtm issues addressed here.
Problems in auto-generated .py files not addressed.
Auto-generated .py files renamed with Ui_ prefix.
The lgtm.yml file must be updated to exclude these
See nasa/cFS#92
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Squashed commit of the following:
adf31d8 
commit 2a8911f
Author: Leor Bleier <[email protected]>
Date:   Fri Jun 26 17:34:54 2020 -0400

    Enhancement nasa#103 - updates to allow user to select header version

    Updates GUI and backend to allow user to select
    header version offsets, or custom byte offsets

commit 9d233eb
Author: Leor Bleier <[email protected]>
Date:   Thu Jun 25 17:12:31 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil and other files

commit 6d3f7ed
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 24 13:53:51 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit 8ad565c
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 24 10:56:45 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit a0d1872
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 23 15:39:25 2020 -0400

    WIP: Enhancement nasa#103 - Implemented native cmdUtil

    Native cmdUtil has only subset of full cmdUtil functionality
    Also implemented updates to GUI and backend to support custom
    byte offsets in tlm and cmd

commit 09261e5
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 16 13:27:26 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Fix for rebase merge error

commit 7754c9f
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 16 12:38:33 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Updated UI and backend to support custom header sizes.
    Change only impacts tlm currently

commit 821f06c
Author: Leor Bleier <[email protected]>
Date:   Mon Jun 1 09:57:02 2020 -0400

    Feature nasa#98 - Refactor UI to table widgets

    Removed unnecessary file

commit b0bd3fa
Author: Leor Bleier <[email protected]>
Date:   Mon Jun 1 09:06:45 2020 -0400

    Feature nasa#98 - Refactor UI to use table widgets

    Backend updated accordingly. Other various tweaks/fixes as needed

commit fb0ccb6
Author: Leor Bleier <[email protected]>
Date:   Wed May 27 16:23:40 2020 -0400

    Fix nasa#46 Recommended lgtm python issues

    Problems shown in this issue were fixed in nasa#72 as part of
    updates/refactoring. Other lgtm issues addressed here.
    Problems in auto-generated .py files not addressed.
    Auto-generated .py files renamed with Ui_ prefix.
    The lgtm.yml file must be updated to exclude these
    See nasa/cFS#92

commit b3d8039
Author: Leor Bleier <[email protected]>
Date:   Wed May 20 07:54:39 2020 -0400

    Fix nasa#88 - Modify GroundSystem to use JSON files generated by CCDD

    Also includes further updates and refinements to overall UI

commit 26486cb
Author: Leor Bleier <[email protected]>
Date:   Thu May 14 11:37:11 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Further edits based on CCB feedback, and other fixes as necessary

commit 876a39d
Author: Leor Bleier <[email protected]>
Date:   Mon May 11 17:08:21 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Includes code cleanup/refactoring. Also fixes nasa#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbleier-GSFC lbleier-GSFC

Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
2 participants
@skliper @lbleier-GSFC