Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #92 - Update lgtm.yml to exclude Ui files #94

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

lbleier-GSFC
Copy link
Contributor

Describe the contribution
Fixes #92 to exclude files in cFS-GroundSystem with the Ui_ prefix

Testing performed
Steps taken to test the contribution:
Pending lgtm run

Expected behavior changes
lgtm analysis should not include Ui_ files

Code contibutions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA GSFC\Code 582

@skliper skliper linked an issue May 29, 2020 that may be closed by this pull request
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
@astrogeco astrogeco merged commit f6a6ef5 into nasa:integration-candidate Jun 2, 2020
@astrogeco
Copy link
Contributor

CCB-2020-06-03: @lbleier-GSFC Look into using GitHub's "release" feature to package UI files

@skliper
Copy link
Contributor

skliper commented Jun 3, 2020

I'd suggest we GitHub's "Release" for official releases and the associated documentation. I'd prefer the deployment model, for which you can deploy artifacts created by travis to a github branch (master could just have the code with .gitignore for all the autogenerated elements, deployed branch could include the generated artifacts from the latest master).

@astrogeco
Copy link
Contributor

astrogeco commented Jun 3, 2020 via email

@lbleier-GSFC
Copy link
Contributor Author

For the issue at hand, I believe the best course of action would be to have the Ui_ files be created during the overall make process. I will create a new issue for this, and see what I can do

yammajamma added a commit that referenced this pull request Sep 21, 2020
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Nothing outside of the codec code should need to know about the bitfields
in the CFDP protocol definition.  Everything else uses logical values.

This moves all DECLARE_FIELD macros into cf_codec.c and removes cf_field.h.
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update lgtm.yml to exclude Ui files
3 participants