New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor individual fields to table #98

Closed

lbleier-GSFC opened this issue May 29, 2020 · 1 comment · Fixed by #100 or #107

Assignees

Labels

Milestone

Contributor

lbleier-GSFC commented May 29, 2020

Is your feature request related to a problem? Please describe.
The individual fields in the generic telemetry and command windows use dozens of individual UI elements.

Describe the solution you'd like
Replace fields with table widget

Additional context
A single table widget would make UI easier to use and maintain

Requester Info
Leor Bleier, NASA GSFC\Code 582

lbleier-GSFC self-assigned this

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to use table widgets

ab60754

Backend updated accordingly. Other various tweaks/fixes as needed

lbleier-GSFC mentioned this issue

Fix #98, Refactor individual UI elements to tables #100

Merged

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to table widgets

db0a550

Removed unnecessary file

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to use table widgets

f2becef

Backend updated accordingly. Other various tweaks/fixes as needed

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to table widgets

b054958

Removed unnecessary file

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to use table widgets

12ceb37

Backend updated accordingly. Other various tweaks/fixes as needed

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - fixed bug

9d96799

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Squashed commit of the following:

c64b413

commit 9d96799
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 17 11:03:46 2020 -0400

    Feature nasa#98 - fixed bug

commit 12ceb37
Author: Leor Bleier <[email protected]>
Date:   Wed May 27 16:23:40 2020 -0400

    Feature nasa#98 - Refactor UI to use table widgets

    Backend updated accordingly. Other various tweaks/fixes as needed

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to use table widgets

1eb8a5c

Backend updated accordingly. Other various tweaks/fixes as needed

Contributor

skliper commented Jun 23, 2020

@lbleier-GSFC please explicitly link this to your pull request.

skliper added this to the 2.2.0 milestone

skliper added the enhancement label

lbleier-GSFC linked a pull request

that will close this issue

Fix #98, Refactor individual UI elements to tables #100

Merged

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Squashed commit of the following:

a68dcda

commit 1eb8a5c
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 17 11:09:28 2020 -0400

    Feature nasa#98 - Refactor UI to use table widgets

    Backend updated accordingly. Other various tweaks/fixes as needed

commit b8017f1
Author: Leor Bleier <[email protected]>
Date:   Wed May 20 07:54:39 2020 -0400

    Fix nasa#88 - Modify GroundSystem to use JSON files generated by CCDD

    Also includes further updates and refinements to overall UI

commit a4c9aae
Author: Leor Bleier <[email protected]>
Date:   Thu May 14 11:37:11 2020 -0400

    Fix nasa#72 - Change pickle load based on CCB feedback

    Other fixes as necessary

commit ab90c9b
Author: Leor Bleier <[email protected]>
Date:   Mon May 11 17:08:21 2020 -0400

    Fix nasa#72 - Includes code cleanup/refactoring

    Also fixes nasa#71

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to use table widgets

b8b70ab

Backend updated accordingly. Other various tweaks/fixes as needed

astrogeco added a commit that referenced this issue


          Merge pull request #100 from lbleier-GSFC/feature98-refactortotables

c7f9072

Fix #98, Refactor individual UI elements to tables

astrogeco mentioned this issue

Integration Candidate: 2020-06-17 #107

Merged

astrogeco closed this as completed in #107

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to use table widgets

b0bd3fa

Backend updated accordingly. Other various tweaks/fixes as needed

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Feature nasa#98 - Refactor UI to table widgets

821f06c

Removed unnecessary file

lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue


          Squashed commit of the following:

adf31d8

commit 2a8911f
Author: Leor Bleier <[email protected]>
Date:   Fri Jun 26 17:34:54 2020 -0400

    Enhancement nasa#103 - updates to allow user to select header version

    Updates GUI and backend to allow user to select
    header version offsets, or custom byte offsets

commit 9d233eb
Author: Leor Bleier <[email protected]>
Date:   Thu Jun 25 17:12:31 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil and other files

commit 6d3f7ed
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 24 13:53:51 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit 8ad565c
Author: Leor Bleier <[email protected]>
Date:   Wed Jun 24 10:56:45 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit a0d1872
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 23 15:39:25 2020 -0400

    WIP: Enhancement nasa#103 - Implemented native cmdUtil

    Native cmdUtil has only subset of full cmdUtil functionality
    Also implemented updates to GUI and backend to support custom
    byte offsets in tlm and cmd

commit 09261e5
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 16 13:27:26 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Fix for rebase merge error

commit 7754c9f
Author: Leor Bleier <[email protected]>
Date:   Tue Jun 16 12:38:33 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Updated UI and backend to support custom header sizes.
    Change only impacts tlm currently

commit 821f06c
Author: Leor Bleier <[email protected]>
Date:   Mon Jun 1 09:57:02 2020 -0400

    Feature nasa#98 - Refactor UI to table widgets

    Removed unnecessary file

commit b0bd3fa
Author: Leor Bleier <[email protected]>
Date:   Mon Jun 1 09:06:45 2020 -0400

    Feature nasa#98 - Refactor UI to use table widgets

    Backend updated accordingly. Other various tweaks/fixes as needed

commit fb0ccb6
Author: Leor Bleier <[email protected]>
Date:   Wed May 27 16:23:40 2020 -0400

    Fix nasa#46 Recommended lgtm python issues

    Problems shown in this issue were fixed in nasa#72 as part of
    updates/refactoring. Other lgtm issues addressed here.
    Problems in auto-generated .py files not addressed.
    Auto-generated .py files renamed with Ui_ prefix.
    The lgtm.yml file must be updated to exclude these
    See nasa/cFS#92

commit b3d8039
Author: Leor Bleier <[email protected]>
Date:   Wed May 20 07:54:39 2020 -0400

    Fix nasa#88 - Modify GroundSystem to use JSON files generated by CCDD

    Also includes further updates and refinements to overall UI

commit 26486cb
Author: Leor Bleier <[email protected]>
Date:   Thu May 14 11:37:11 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Further edits based on CCB feedback, and other fixes as necessary

commit 876a39d
Author: Leor Bleier <[email protected]>
Date:   Mon May 11 17:08:21 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Includes code cleanup/refactoring. Also fixes nasa#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment