Fix #651, Use resource ID for memory pools #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
Instead of identifying a memory pool by its memory address, use a resource ID. IDs are a constant size, regardless of whether the host machine is 32 or 64 bits. - IDs can be put into commands/telemetry and maintain a more consistent format with consistent alignment requirements. - IDs can be independently verified without dereferencing memory. Previously the only way to validate a memory pool was to read the address pointed to, which results in a SEGV if the address was bad.
jphickey
force-pushed
the
fix-651-abstract-mempool-id
branch
from
dc51842
to
f6ae2fb
Compare
astrogeco
added
CCB-20200930
and removed
CCB:Ready
|
Confirmed this also fixes #854 |
APPROVED |
This was referenced Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Instead of identifying a memory pool by its memory address, use a resource ID. IDs are a constant size, regardless of
whether the host machine is 32 or 64 bits.
Fixes #651
Testing performed
Build and sanity test CFE, run all unit tests
Confirm code coverage up to par.
Expected behavior changes
The
CFE_ES_MemHandle_ttype is no longer a direct CPU address. Instead it is an abstract resource identifier.This should fix issues with unexpected padding of CMD/TLM messages that contain memory pool handles.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11
Additional context
Fairly extensive changes in the memory pool implementation to support abstract handles, but the API exposed to applications should be backward compatible, so long as apps did not rely on the specific pool layout.
The downside is that there is a limit to the total number of abstract identifiers that can exist, which is a new platform config limit.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.