Cast align issue in cfe_es_task.c - CFE_ES_TaskPipe

[skliper]

Describe the bug

/home/jhageman/cFS-GitHub/cfe/fsw/cfe-core/src/es/cfe_es_task.c: In function ‘CFE_ES_TaskPipe’:
/home/jhageman/cFS-GitHub/cfe/fsw/cfe-core/src/es/cfe_es_task.c:635:52: warning: cast increases required alignment of target type [-Wcast-align]
  635 |                         CFE_ES_SendMemPoolStatsCmd((CFE_ES_SendMemPoolStats_t*)Msg);

To Reproduce
Build on gcc 8+ with cast-align=strict

Expected behavior
Clean build

Code snips

cFE/fsw/cfe-core/src/es/cfe_es_task.c

Lines 632 to 637 in 06c0826

	case CFE_ES_SEND_MEM_POOL_STATS_CC:
	if (CFE_ES_VerifyCmdLength(Msg, sizeof(CFE_ES_SendMemPoolStats_t)))
	{
	CFE_ES_SendMemPoolStatsCmd((CFE_ES_SendMemPoolStats_t*)Msg);
	}
	break;

System observed on:

• Hardware: arm64
• OS: Ubuntu 20.04
• Versions bundle + mods to cast-align=strict

Additional context
#851, #852

Reporter Info
Jacob Hageman - NASA/GSFC

[skliper]

@jphickey are you fixing this with the other mempool command issues (reference instead of raw address)?

[jphickey]

Yes, the reason this message has increased alignment needs is because it contains a cpuaddr type. When replaced with an abstract pool handle (which can be uint32) the alignment issue goes away.

[skliper]

Confirmed this has been resolved (via #917). Closing