Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate CDS and generic/ram mempool code into single implementation #56

Closed
skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #939 or #944
Closed

Consolidate CDS and generic/ram mempool code into single implementation #56

skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #939 or #944
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Currently there are two memory pool implementations in ES:

  • cfe_es_cds_mempool.c
  • cfe_esmempool.c

These two are very similar except that the CDS uses offsets rather than direct pointers, and it calls into the PSP to perform actual read/write functions. It would not be very hard to consolidate these into a single implementation.

Each implementation consumes about 4-5kB of code/data space so this consolidation would make ES a little smaller in addition to making it cleaner.
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 25. Created by jphickey on 2015-01-21T13:33:26, last modified: 2019-03-01T15:27:58

@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-05-19 09:39:35:

This is an old enhancement that is yet to be merged in. Higher priority items taking precedence right now.

@skliper skliper assigned jphickey and unassigned skliper Sep 30, 2019
@jphickey jphickey mentioned this issue Aug 18, 2020
Closed
@jphickey
Copy link
Contributor

jphickey commented Oct 2, 2020

With recent addition of a generic (offset-based) memory pool implementation that works with the abstract resource IDs in #917. I have also tested that this works for CDS blocks too. Discussed at 2020-09-30 CCB that this would be a good time to finally do this and make one mempool implementation.

@jphickey jphickey mentioned this issue Oct 2, 2020
Merged
@skliper skliper added this to the 7.0.0 milestone Oct 2, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Oct 7, 2020
@jphickey
Fix nasa#56, Refactor CDS to use generic pool implementation
af4f72a 
Rather than having a second pool implementation only for CDS, use
the generic pool implementation.  This also uses the abstract resource
identifiers to identify CDS blocks, rather than a direct reference.
@jphickey jphickey mentioned this issue Oct 7, 2020
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Oct 7, 2020
@jphickey
Fix nasa#56, Refactor CDS to use generic pool implementation
daf6c04 
Rather than having a second pool implementation only for CDS, use
the generic pool implementation.  This also uses the abstract resource
identifiers to identify CDS blocks, rather than a direct reference.
astrogeco added a commit that referenced this issue Oct 13, 2020
@astrogeco
Merge pull request #939 from jphickey/fix-56-cds-mempool-consolidate
85469ce 
Fix #56, Refactor CDS to use generic pool implementation
@astrogeco astrogeco mentioned this issue Oct 13, 2020
Merged
@skliper skliper mentioned this issue Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper