feat(editor): Add disable template experiment #5963

RicardoE105 · 2023-04-12T20:48:43Z

Github issue / Community forum post (link here to close automatically):

github-actions · 2023-04-12T20:49:18Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

codecov · 2023-04-12T21:03:56Z

Codecov Report

Patch coverage: 60.41% and project coverage change: -0.01 ⚠️

Comparison is base (589f19e) 18.72% compared to head (1ad9256) 18.71%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5963      +/-   ##
==========================================
- Coverage   18.72%   18.71%   -0.01%     
==========================================
  Files        2582     2582              
  Lines      116475   116510      +35     
  Branches    18175    18178       +3     
==========================================
- Hits        21810    21805       -5     
- Misses      94027    94067      +40     
  Partials      638      638

Impacted Files	Coverage Δ
packages/editor-ui/src/utils/nodeTypesUtils.ts	`26.84% <ø> (+0.04%)`	⬆️
packages/editor-ui/src/router.ts	`87.37% <28.57%> (-0.44%)`	⬇️
packages/editor-ui/src/stores/settings.ts	`74.48% <33.33%> (-0.37%)`	⬇️
packages/editor-ui/src/stores/posthog.ts	`77.47% <61.29%> (-3.16%)`	⬇️
packages/editor-ui/src/constants.ts	`98.17% <100.00%> (+0.02%)`	⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages/editor-ui/src/stores/posthog.ts

github-actions · 2023-04-17T07:47:41Z

✅ All Cypress E2E specs passed

packages/editor-ui/src/stores/posthog.ts

github-actions · 2023-04-17T09:16:28Z

✅ All Cypress E2E specs passed

github-actions · 2023-04-17T11:39:36Z

✅ All Cypress E2E specs passed

packages/editor-ui/src/stores/posthog.ts

mutdmour · 2023-04-21T07:12:07Z

packages/editor-ui/src/stores/posthog.ts

+				name,
+				variant,
+			});
+		}, 2000);


this is now 4 seconds later for debounced? would 0 just work here?

github-actions · 2023-04-21T07:12:25Z

✅ All Cypress E2E specs passed

github-actions · 2023-04-21T08:26:09Z

✅ All Cypress E2E specs passed

mutdmour · 2023-04-21T08:34:24Z

fyi @RicardoE105 decided to push this through today

figured we could just avoid the time delay on evaluation by splitting it from tracking
kept original debounce for tracking since that worked
cleaned up file, added some comments

* master: (199 commits) feat(editor): Add disable template experiment (#5963) feat(core): Upgrade google-timezones-json to use the correct timezone for Sao Paulo (#6042) fix(Code Node): Update vm2 to address CVE-2023-30547 (#6039) docs: Add proprietary license text (no-changelog) (#6038) test(n8n Node): Unit tests (no-changelog) refactor: Accumulate `loadOptions` from all node versions to validate (no-changelog) (#6014) Update CHANGELOG.md feat: Add variables e2e tests (no-changelog) (#6027) fix(editor): Fix typo in SSO upgrade link (#6031) fix(editor): Add correct add variable button message when no variables created (no-changelog) (#6028) docs: Add api notice to credentials for google sheets nodes (no-changelog) (#6024) fix(Notion Node): Update credential test to not require user permissions (#6022) fix(editor): Clean up demo and template callouts from workflows page (#6023) fix(editor): Fix memory leak in Node Detail View by correctly unsubscribing from event buses (#6021) fix(editor): SettingsSidebar should disconnect from push when navigating away (#6025) fix(editor): Use fake timers in useDebounce.test.ts to make the test less flaky (no-changelog) (#6029) docs: Update the info URL for updating n8n (no-changelog) (#6018) fix(core): Improve domain and url matching for extractDomain and extractUrl (#6010) feat(core): Add SSH key generation (#6006) fix(editor): Update SSO upgrade link (#6016) ... # Conflicts: # packages/editor-ui/src/components/WorkflowShareModal.ee.vue # packages/editor-ui/src/stores/workflows.ts # packages/editor-ui/src/views/NodeView.vue

* master: (47 commits) feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) (#6033) feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940) feat(core): Add license:info command (#6047) feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) (#6050) refactor(editor): Turn titleChange mixin to composable (#6059) test: Add stickies tests (#5413) refactor: Patch to adjust `consistent-type-imports` (no-changelog) (#6057) fix(editor): Resolve expressions for grandparent nodes (#5859) ci(editor): Do not run parallel jobs for a single spec (no-changelog) (#6052) refactor(editor): Consolidate IN8nUISettings interface (#6055) refactor(core): Forbid raw enums (no-changelog) refactor(core): Sort variables files under variables folder (#6051) fix(core): Add breaking change record for domain and url matching (no-changelog) (#6048) feat(editor): Version control paywall (WIP) (#6030) feat(editor): Add disable template experiment (#5963) feat(core): Upgrade google-timezones-json to use the correct timezone for Sao Paulo (#6042) fix(Code Node): Update vm2 to address CVE-2023-30547 (#6039) docs: Add proprietary license text (no-changelog) (#6038) test(n8n Node): Unit tests (no-changelog) refactor: Accumulate `loadOptions` from all node versions to validate (no-changelog) (#6014) ... # Conflicts: # packages/cli/src/Server.ts

* Add remove templates experiments * Add track experiment without debouncing * Allow to go to templates route even when experiment is active * Add missing import * Fix linting issue * Remove unused constant * Add timeout to track "User is part of experiment" event * fix: split experiment evaluation from tracking * fix: fix overrides * chore: remove console --------- Co-authored-by: Mutasem <[email protected]>

janober · 2023-05-02T10:16:28Z

Got released with [email protected]

Add remove templates experiments

43562e3

n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 12, 2023

RicardoE105 requested a review from mutdmour April 13, 2023 01:36

mutdmour reviewed Apr 13, 2023

View reviewed changes

packages/editor-ui/src/stores/posthog.ts Outdated Show resolved Hide resolved

RicardoE105 added 2 commits April 13, 2023 10:25

Add track experiment without debouncing

1eefd3f

Allow to go to templates route even when experiment is active

339cf64

RicardoE105 requested a review from mutdmour April 13, 2023 14:30

mutdmour approved these changes Apr 17, 2023

View reviewed changes

mutdmour requested changes Apr 17, 2023

View reviewed changes

packages/editor-ui/src/stores/posthog.ts Outdated Show resolved Hide resolved

Add missing import

76afccb

RicardoE105 requested a review from mutdmour April 17, 2023 11:41

mutdmour reviewed Apr 18, 2023

View reviewed changes

packages/editor-ui/src/stores/posthog.ts Outdated Show resolved Hide resolved

RicardoE105 added 4 commits April 20, 2023 16:35

sync master

eeb7db6

Fix linting issue

5f8bd28

Remove unused constant

5214784

Add timeout to track "User is part of experiment" event

e85bedc

RicardoE105 requested a review from mutdmour April 20, 2023 21:53

mutdmour reviewed Apr 21, 2023

View reviewed changes

mutdmour added 3 commits April 21, 2023 09:39

fix: split experiment evaluation from tracking

ba28d2e

fix: fix overrides

717d316

chore: remove console

1ad9256

mutdmour approved these changes Apr 21, 2023

View reviewed changes

mutdmour merged commit a74284b into master Apr 21, 2023

mutdmour deleted the ado-478-experiment-remove-templates branch April 21, 2023 08:32

janober added the Released label May 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(editor): Add disable template experiment #5963

feat(editor): Add disable template experiment #5963

Uh oh!

RicardoE105 commented Apr 12, 2023

Uh oh!

github-actions bot commented Apr 12, 2023

Uh oh!

codecov bot commented Apr 12, 2023 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

Uh oh!

mutdmour Apr 21, 2023

Uh oh!

github-actions bot commented Apr 21, 2023

Uh oh!

github-actions bot commented Apr 21, 2023

Uh oh!

mutdmour commented Apr 21, 2023

Uh oh!

janober commented May 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(editor): Add disable template experiment #5963

feat(editor): Add disable template experiment #5963

Uh oh!

Conversation

RicardoE105 commented Apr 12, 2023

Uh oh!

github-actions bot commented Apr 12, 2023

Uh oh!

codecov bot commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

Uh oh!

mutdmour Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 21, 2023

Uh oh!

github-actions bot commented Apr 21, 2023

Uh oh!

mutdmour commented Apr 21, 2023

Uh oh!

janober commented May 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Apr 12, 2023 •

edited

Loading