-
Notifications
You must be signed in to change notification settings - Fork 50.5k
feat(editor): Add disable template experiment #5963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
43562e3
Add remove templates experiments
RicardoE105 1eefd3f
Add track experiment without debouncing
RicardoE105 339cf64
Allow to go to templates route even when experiment is active
RicardoE105 76afccb
Add missing import
RicardoE105 eeb7db6
sync master
RicardoE105 5f8bd28
Fix linting issue
RicardoE105 5214784
Remove unused constant
RicardoE105 e85bedc
Add timeout to track "User is part of experiment" event
RicardoE105 ba28d2e
fix: split experiment evaluation from tracking
mutdmour 717d316
fix: fix overrides
mutdmour 1ad9256
chore: remove console
mutdmour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,11 @@ import { useUsersStore } from '@/stores/users'; | |
| import { useRootStore } from '@/stores/n8nRootStore'; | ||
| import { useSettingsStore } from '@/stores/settings'; | ||
| import { FeatureFlags } from 'n8n-workflow'; | ||
| import { EXPERIMENTS_TO_TRACK, LOCAL_STORAGE_EXPERIMENT_OVERRIDES } from '@/constants'; | ||
| import { | ||
| EXPERIMENTS_TO_TRACK, | ||
| LOCAL_STORAGE_EXPERIMENT_OVERRIDES, | ||
| TEMPLATE_EXPERIMENT, | ||
| } from '@/constants'; | ||
| import { useTelemetryStore } from './telemetry'; | ||
| import { useSegment } from './segment'; | ||
| import { debounce } from 'lodash-es'; | ||
|
|
@@ -128,12 +132,16 @@ export const usePostHog = defineStore('posthog', () => { | |
| window.posthog?.onFeatureFlags?.((keys: string[], map: FeatureFlags) => { | ||
| featureFlags.value = map; | ||
| addExperimentOverrides(); | ||
| trackExperiments(map); | ||
| trackExperimentsDebounced(map); | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| const trackExperiments = debounce((featureFlags: FeatureFlags) => { | ||
| const trackExperiments = (featureFlags: FeatureFlags) => { | ||
| EXPERIMENTS_TO_TRACK.forEach((name) => trackExperiment(featureFlags, name)); | ||
| }; | ||
|
|
||
| const trackExperimentsDebounced = debounce((featureFlags: FeatureFlags) => { | ||
| EXPERIMENTS_TO_TRACK.forEach((name) => trackExperiment(featureFlags, name)); | ||
| }, 2000); | ||
|
|
||
|
|
@@ -143,12 +151,18 @@ export const usePostHog = defineStore('posthog', () => { | |
| return; | ||
| } | ||
|
|
||
| telemetryStore.track(EVENTS.IS_PART_OF_EXPERIMENT, { | ||
| name, | ||
| variant, | ||
| }); | ||
| setTimeout(() => { | ||
| telemetryStore.track(EVENTS.IS_PART_OF_EXPERIMENT, { | ||
| name, | ||
| variant, | ||
| }); | ||
| }, 2000); | ||
|
||
|
|
||
| trackedDemoExp.value[name] = variant; | ||
|
|
||
| if (name === TEMPLATE_EXPERIMENT.name && variant === TEMPLATE_EXPERIMENT.variant) { | ||
RicardoE105 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| settingsStore.disableTemplates(); | ||
RicardoE105 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| }; | ||
|
|
||
| return { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.