refactor: Patch to adjust consistent-type-imports (no-changelog)
#6057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstuncsik
approved these changes
Apr 21, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6057 +/- ##
==========================================
- Coverage 18.72% 18.65% -0.07%
==========================================
Files 2583 2582 -1
Lines 116526 116392 -134
Branches 18181 18176 -5
==========================================
- Hits 21821 21717 -104
+ Misses 94067 94037 -30
Partials 638 638 see 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 21, 2023
* master: feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940) feat(core): Add license:info command (#6047) feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) (#6050) refactor(editor): Turn titleChange mixin to composable (#6059) test: Add stickies tests (#5413) refactor: Patch to adjust `consistent-type-imports` (no-changelog) (#6057) # Conflicts: # packages/editor-ui/src/components/ExecutionsView/ExecutionPreview.vue # packages/editor-ui/src/mixins/workflowRun.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 24, 2023
* master: (47 commits) feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) (#6033) feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940) feat(core): Add license:info command (#6047) feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) (#6050) refactor(editor): Turn titleChange mixin to composable (#6059) test: Add stickies tests (#5413) refactor: Patch to adjust `consistent-type-imports` (no-changelog) (#6057) fix(editor): Resolve expressions for grandparent nodes (#5859) ci(editor): Do not run parallel jobs for a single spec (no-changelog) (#6052) refactor(editor): Consolidate IN8nUISettings interface (#6055) refactor(core): Forbid raw enums (no-changelog) refactor(core): Sort variables files under variables folder (#6051) fix(core): Add breaking change record for domain and url matching (no-changelog) (#6048) feat(editor): Version control paywall (WIP) (#6030) feat(editor): Add disable template experiment (#5963) feat(core): Upgrade google-timezones-json to use the correct timezone for Sao Paulo (#6042) fix(Code Node): Update vm2 to address CVE-2023-30547 (#6039) docs: Add proprietary license text (no-changelog) (#6038) test(n8n Node): Unit tests (no-changelog) refactor: Accumulate `loadOptions` from all node versions to validate (no-changelog) (#6014) ... # Conflicts: # packages/cli/src/Server.ts
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…8n-io#6057) 📦 Patch dependency
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consistent-type-importsis unable to detect usage of components inside Vue templates, causing misfixes of component imports to type imports. This patch for the rule skips over imports where the path ends in.vue, preventing misdetection. This assumes.vueimports are always needed as value imports.To test:
'@typescript-eslint/consistent-type-imports': 'error'topackages/@n8n_io/eslint-config/base.jspackages/editor-ui/src/components/Node/NodeCreator/CategorizedItems.vueat L102 → Lineimport SearchBar from './SearchBar.vue';should not be flagged.Related: #5951