feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) #6050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6050 +/- ##
==========================================
- Coverage 18.72% 18.71% -0.01%
==========================================
Files 2582 2584 +2
Lines 116475 116581 +106
Branches 18175 18182 +7
==========================================
+ Hits 21810 21821 +11
- Misses 94027 94122 +95
Partials 638 638
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mutdmour
previously approved these changes
Apr 21, 2023
packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Mutasem Aldmour <[email protected]>
mutdmour
approved these changes
Apr 21, 2023
Contributor
|
✅ All Cypress E2E specs passed |
1 similar comment
Contributor
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 21, 2023
* master: feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940) feat(core): Add license:info command (#6047) feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) (#6050) refactor(editor): Turn titleChange mixin to composable (#6059) test: Add stickies tests (#5413) refactor: Patch to adjust `consistent-type-imports` (no-changelog) (#6057) # Conflicts: # packages/editor-ui/src/components/ExecutionsView/ExecutionPreview.vue # packages/editor-ui/src/mixins/workflowRun.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 24, 2023
* master: (47 commits) feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) (#6033) feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940) feat(core): Add license:info command (#6047) feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) (#6050) refactor(editor): Turn titleChange mixin to composable (#6059) test: Add stickies tests (#5413) refactor: Patch to adjust `consistent-type-imports` (no-changelog) (#6057) fix(editor): Resolve expressions for grandparent nodes (#5859) ci(editor): Do not run parallel jobs for a single spec (no-changelog) (#6052) refactor(editor): Consolidate IN8nUISettings interface (#6055) refactor(core): Forbid raw enums (no-changelog) refactor(core): Sort variables files under variables folder (#6051) fix(core): Add breaking change record for domain and url matching (no-changelog) (#6048) feat(editor): Version control paywall (WIP) (#6030) feat(editor): Add disable template experiment (#5963) feat(core): Upgrade google-timezones-json to use the correct timezone for Sao Paulo (#6042) fix(Code Node): Update vm2 to address CVE-2023-30547 (#6039) docs: Add proprietary license text (no-changelog) (#6038) test(n8n Node): Unit tests (no-changelog) refactor: Accumulate `loadOptions` from all node versions to validate (no-changelog) (#6014) ... # Conflicts: # packages/cli/src/Server.ts
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…gelog) (n8n-io#6050) * refactor: use InstanceType<T> for all this.$refs types * refactor: update refs type in N8nSelect * fix: remove inputRef non-null assertion Co-authored-by: Mutasem Aldmour <[email protected]> * fix: remove non-null assertion --------- Co-authored-by: Mutasem Aldmour <[email protected]>
Member
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):