#10670: Add AGENTS.md for AI coding assistant guidance - #601
Conversation
Adds a root AGENTS.md hub covering the repository as a whole, plus per-module AGENTS.md guides for mock-identity-system, mock-relying-party-service, mock-relying-party-ui, mock-relying-party-ui-esim, and partner-onboarder — the independently buildable modules in this repo. Each guide documents purpose, layout, how to run/build/test, configuration, and explicit agent do/do-not rules, verified against the actual READMEs, pom.xml/package.json files, and GitHub Actions workflows in this repo. Addresses mosip/mosip-config#10670 Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
WalkthroughAdded root and module-level ChangesRepository agent guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 124-125: Update the root testing/build guidance near “Run the
relevant module's tests/build” to avoid prescribing npm test for every
Node/React module. Direct contributors to use each module’s documented commands,
including the module-specific guidance in mock-relying-party-service/AGENTS.md,
while retaining the Java module’s Maven command and applicable Node/React build
instructions.
In `@mock-identity-system/AGENTS.md`:
- Around line 31-35: Update the local setup command in AGENTS.md to reference
docker-compose/dependent-docker-compose.yml from the repository root, while
leaving the Maven command and surrounding setup instructions unchanged.
In `@mock-relying-party-ui-esim/AGENTS.md`:
- Around line 31-47: Update the Docker example in AGENTS.md to use
MOCK_RELYING_PARTY_SERVER_URL instead of MOCK_RELYING_PARTY_BASE_URL, matching
the variable consumed by the Dockerfile and UI. Keep the example’s value and all
other environment variables unchanged.
In `@partner-onboarder/AGENTS.md`:
- Around line 7-11: Update the onboarding documentation in AGENTS.md and the
“Esignet K8 cluster” wording in install.sh to explicitly target non-production
eSignet/Kubernetes clusters only, replacing language that could imply production
support while preserving the existing onboarding purpose and identity-plugin
context.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f0fa5550-2081-4c42-8ffb-ccfb0fb92abf
📒 Files selected for processing (6)
AGENTS.mdmock-identity-system/AGENTS.mdmock-relying-party-service/AGENTS.mdmock-relying-party-ui-esim/AGENTS.mdmock-relying-party-ui/AGENTS.mdpartner-onboarder/AGENTS.md
- Stop prescribing npm test for every Node/React module; point to each module's own AGENTS.md/README.md since scripts differ (mock-relying-party-service has no test script at all). - Fix docker-compose path in mock-identity-system/AGENTS.md: from the repo root it's docker-compose/, not ../docker-compose/. - Use MOCK_RELYING_PARTY_SERVER_URL in the mock-relying-party-ui-esim Docker example, matching the variable the Dockerfile/UI actually read (MOCK_RELYING_PARTY_BASE_URL has no effect). - Note that partner-onboarder targets a non-production eSignet deployment only, per the root README's repo-wide scope. Addresses review comments on mosip#601 Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
AGENTS.md (1)
167-171: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winCover
partner-onboarderin the validation and configuration rules.Lines 167-171 list only Maven and npm validation and environment variables or properties files. However, Lines 29, 49, and 97 define
partner-onboarderas a shell/Helm module configured throughpartner-onboarder/values.yaml. Agents can skip its documented validation or use the wrong configuration surface.Add the shell/Helm validation command and include
values.yamlin this rule.As per coding guidelines, each changed module must use its own documented build/test workflow.
Proposed wording
-2. Build and test the specific module you changed before proposing a PR (Maven for - `mock-identity-system`, `npm` for the Node/React modules). -3. Keep any new configuration documented as environment variables or properties files - consistent with the patterns already used in that module (no new secrets committed to the - repo). +2. Build and test the specific module you changed before proposing a PR, using its + documented workflow: Maven for `mock-identity-system`, npm for the Node/React + modules, and the shell/Helm commands in `partner-onboarder/AGENTS.md` for + `partner-onboarder`. +3. Keep new configuration documented in the module's existing configuration surface, + including environment variables, properties, UI runtime configuration, or + `partner-onboarder/values.yaml`, as applicable. Do not commit secrets.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@AGENTS.md` around lines 167 - 171, Update the module validation and configuration guidance around the listed Maven/npm workflows to also cover the partner-onboarder shell/Helm module: specify its documented shell/Helm validation command and recognize partner-onboarder/values.yaml as a valid configuration surface, while preserving the existing module-specific workflow and no-secrets requirements.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@AGENTS.md`:
- Around line 167-171: Update the module validation and configuration guidance
around the listed Maven/npm workflows to also cover the partner-onboarder
shell/Helm module: specify its documented shell/Helm validation command and
recognize partner-onboarder/values.yaml as a valid configuration surface, while
preserving the existing module-specific workflow and no-secrets requirements.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 061332b5-5a26-4c74-a16b-467e8b7792dd
📒 Files selected for processing (4)
AGENTS.mdmock-identity-system/AGENTS.mdmock-relying-party-ui-esim/AGENTS.mdpartner-onboarder/AGENTS.md
* Added PKCE implementation Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> * fixed coderabbit comment Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> * Corrected the logic to full dynamic identity schema Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Fixed review comments Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * added proxy pass for par and dpop (#554) Signed-off-by: Harsh Kashiwal <harsh.kashiwal@infosys.com> * resolved comments Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> * resolved review comment Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> * resolve review comments Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> * set active_profile_env to "default" in deployment (#558) (#560) Signed-off-by: Sachin Rana <sacrana324@gmail.com> * docs: fix typos, remove duplicate overview, and improve README formatting (#561) (#563) Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * Added endpoint to fetch identity schema (#564) * Added endpoint to fetch identity schema Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Added endpoint to fetch identity schema Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Fixed testcase Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> --------- Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Fixed the required field validation error (#565) * Added endpoint to fetch identity schema Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Added endpoint to fetch identity schema Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Fixed required fields validation error Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> --------- Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Snapshot updates 0.13.0 -> 0.13.1 Signed-off-by: Harsh Kashiwal <kashiwalharsh1234@gmail.com> * [ES-2962] Added error messages for login_required and request_not_supported error. Signed-off-by: GurukiranP <talk2gurukiran@gmail.com> * [ES-1616] Added new error message. Signed-off-by: GurukiranP <talk2gurukiran@gmail.com> * [MOSIP-37808] Updated DB attributes of MOSIP esignet-mock Signed-off-by: Abhi <abhishek.shankarcs@gmail.com> * [MOSIP-37808] Updated DB attributes of MOSIP esignet-mock (#579) Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> * Updating sign-in-with-esignet, removing optional parameter from config (#590) * [MODIFIED] used npm library for sign-in-with-esignet Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [MODIFIED] ignore optional parameter in sign-in-with-esignet Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [MODIFIED] readme file Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [MODIFIED] coderabbit comment resolved Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [MODIFIED] review comment addressed Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [MODIFIED] readme updated Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> --------- Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [1996] added configurable token and userinfo endpoint (#591) * [1996] added configurable token and userinfo endpoint Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [1996] add kid only, if private key has it Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [1996] default value of token & userinfo endpoint Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> --------- Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [1966] bypass for json userInfoResponse (#592) * [1966] bypass for json userInfoResponse Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [1966] bypass for json userInfoResponse Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> --------- Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [mosip/mosip-infra#1890] Added domainConfig support in helm charts (#589) * [mosip/mosip-infra#1890] Removed esignet-global, added domainConfig support in helm charts Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [mosip/mosip-infra#1890] Set chart versions to 0.0.1-develop Signed-off-by: bhumi46 <thisisbn46@gmail.com> * migrate to domainConfig helm values #1890 Signed-off-by: bhumi46 <thisisbn46@gmail.com> --------- Signed-off-by: bhumi46 <thisisbn46@gmail.com> Co-authored-by: bhumi46 <bhumi11111a@gmail.com> * Gpg update Test (#596) * ci: point kattu maven workflows at @develop to test kattu#353 Repoints maven-build / maven-publish-to-nexus / maven-sonar-analysis(-new) reusable-workflow references to mosip/kattu@develop so the GPG-key-import migration (mosip/kattu#353) is exercised by this repo's CI once it merges. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in> * ci: pass GPG_PRIVATE_KEY secret from caller workflows (kattu#353) kattu#353 imports the signing key from the GPG_PRIVATE_KEY secret (now required: true in maven-build / maven-publish-to-nexus workflow_call), so the caller must forward it. Added GPG_PRIVATE_KEY to the maven-build and maven-publish-to-nexus caller jobs only (sonar workflows don't declare it). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in> * ci: point maven workflows at Mahesh-Binayak/kattu@gpgupdate-masterj21 gpgupdate-masterj21 = master-java21 + the GPG-secret-import / key-age / simplify4u-pgpverify changes, keeping master-java21's interface intact. Repoints maven-build / maven-publish-to-nexus / maven-sonar-analysis to it, restores MAVEN_NON_EXEC_ARTIFACTS, and forwards GPG_PRIVATE_KEY to the build/publish jobs. Other workflows (docker-build, npm-*, sonar-new@develop) and commented refs are left unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in> * ci: point maven workflows at mosip/kattu@gpgupdate-masterj21 The gpgupdate-masterj21 branch now lives on mosip/kattu; reference it there instead of the fork. Interface unchanged; GPG_PRIVATE_KEY forwarded. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in> --------- Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> * [issue:1963] Updated helm for thunder deployment (#593) Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com> * [issue:597] Add PKCS12 keystore support to mock-identity-system as an alternative to SoftHSM (#599) install.sh now prompts to opt into a PKCS12 mounted-volume keystore instead of SoftHSM; SoftHSM provisioning only runs when PKCS12 isn't selected. The chart gained a PersistentVolumeClaim template, a fixed volume-permissions init container (was a literal unfilled placeholder), persistence volume wiring in the deployment, and additive extraEnvVarsAdditional support. Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in> * Fix default prompt value (#600) Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> Co-authored-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> * #10670: Add AGENTS.md tree for AI coding assistant guidance Adds a root AGENTS.md hub covering the repository as a whole, plus per-module AGENTS.md guides for mock-identity-system, mock-relying-party-service, mock-relying-party-ui, mock-relying-party-ui-esim, and partner-onboarder — the independently buildable modules in this repo. Each guide documents purpose, layout, how to run/build/test, configuration, and explicit agent do/do-not rules, verified against the actual READMEs, pom.xml/package.json files, and GitHub Actions workflows in this repo. Addresses mosip/mosip-config#10670 Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com> * #10670: Address CodeRabbit review feedback on AGENTS.md - Stop prescribing npm test for every Node/React module; point to each module's own AGENTS.md/README.md since scripts differ (mock-relying-party-service has no test script at all). - Fix docker-compose path in mock-identity-system/AGENTS.md: from the repo root it's docker-compose/, not ../docker-compose/. - Use MOCK_RELYING_PARTY_SERVER_URL in the mock-relying-party-ui-esim Docker example, matching the variable the Dockerfile/UI actually read (MOCK_RELYING_PARTY_BASE_URL has no effect). - Note that partner-onboarder targets a non-production eSignet deployment only, per the root README's repo-wide scope. Addresses review comments on #601 Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com> * fix: 602 convert extraEnvVars/extraEnvVarsAdditional to maps (#603) * fix: 602 convert extraEnvVars/extraEnvVarsAdditional to maps Helm merges map keys across values layers but replaces lists wholesale, so any downstream override of extraEnvVars/extraEnvVarsAdditional had to re-declare the whole list just to change one entry. Convert both to maps keyed by env var name in mock-identity-system, mock-relying-party-service, and mock-relying-party-ui, and render them with a range loop that auto-detects plain scalars vs. valueFrom, matching the existing domainConfig pattern already used in these charts. Same fix already applied to mosip/esignet (issue #2380). Signed-off-by: bhumi46 <thisisbn46@gmail.com> * fix: 602 update mock-identity-system installer for extraEnvVarsAdditional map contract deploy/mock-identity-system/install.sh generated extraEnvVarsAdditional as a list in two places (PKCS12 and softhsm branches), which produced broken index-keyed env entries against the chart's map-shaped default introduced in this PR. Convert both to the map contract (KEY: value / KEY: {valueFrom: ...}), matching the fix already applied to esignet's legacy installer scripts. Signed-off-by: bhumi46 <thisisbn46@gmail.com> --------- Signed-off-by: bhumi46 <thisisbn46@gmail.com> * Change image tag from release-0.10.x to develop Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * Change image tag from release-0.10.x to develop Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * Change image tag from release-0.10.x to develop Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * #2347 Update database host and clean up configuration (#610) Updated the host to include the namespace and removed unused service configurations. Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> * #2347 Update database username in postgres config (#611) * #2347 Update database username in postgres config Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> * #2347 Update database username in deploy.properties Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> --------- Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> * updated version 0.13.0 to 0.14.0 Signed-off-by: Sachin Rana <sacrana324@gmail.com> * updated helm chart version Signed-off-by: Sachin Rana <sacrana324@gmail.com> --------- Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Harsh Kashiwal <harsh.kashiwal@infosys.com> Signed-off-by: Sachin Rana <sacrana324@gmail.com> Signed-off-by: Nandhukumar <nandhukumare@gmail.com> Signed-off-by: Harsh Kashiwal <kashiwalharsh1234@gmail.com> Signed-off-by: GurukiranP <talk2gurukiran@gmail.com> Signed-off-by: Abhi <abhishek.shankarcs@gmail.com> Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> Signed-off-by: bhumi46 <thisisbn46@gmail.com> Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in> Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com> Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in> Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com> Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> Co-authored-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com> Co-authored-by: ase-101 <sunkadaeanusha@gmail.com> Co-authored-by: Zeeshan Mehboob <82993262+zesu22@users.noreply.github.com> Co-authored-by: Harsh Kashiwal <77677724+KashiwalHarsh@users.noreply.github.com> Co-authored-by: Nandhukumar <nandhukumare@gmail.com> Co-authored-by: Harsh Kashiwal <kashiwalharsh1234@gmail.com> Co-authored-by: GurukiranP <talk2gurukiran@gmail.com> Co-authored-by: Abhi <abhishek.shankarcs@gmail.com> Co-authored-by: Chandra Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> Co-authored-by: bhumi46 <111699703+bhumi46@users.noreply.github.com> Co-authored-by: bhumi46 <bhumi11111a@gmail.com> Co-authored-by: Mahesh-Binayak <76687012+Mahesh-Binayak@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Praful Rakhade <prafulrakhade02@gmail.com> Co-authored-by: Swapnil <swapnil.mohanty@technoforte.co.in> Co-authored-by: Sajid Mannikeri <sajid.mannikeri@infosys.com> Co-authored-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
Addresses mosip/mosip-config#10670 — adds a root AGENTS.md hub plus per-module AGENTS.md guides (mock-identity-system, mock-relying-party-service, mock-relying-party-ui, mock-relying-party-ui-esim, partner-onboarder) documenting purpose, layout, build/run/test commands, configuration, and agent do/do-not rules for AI coding assistants.
Summary by CodeRabbit