[1966] bypass for json userInfoResponse

[zesu22]

• handle userinfo response flow when JSON response comes up instead of JWS or JWE

Summary by CodeRabbit

• Bug Fixes
  • Improved user info response handling by detecting when the payload is already in JSON/object form and using it directly.
  • This prevents unnecessary decoding attempts and ensures the application correctly parses and consumes user data regardless of whether it arrives as an already-decoded object or an encoded token.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6b2b302a-367c-4e66-8638-be3f534956a6

📥 Commits

Reviewing files that changed from the base of the PR and between 3da6709 and c8e470d.

📒 Files selected for processing (1)

• mock-relying-party-service/utils.js

---

Walkthrough

Updates decodeUserInfoResponse in mock-relying-party-service/utils.js to short-circuit when the input is already a non-null object: it logs that the payload is already an object and returns it directly, bypassing the existing JWE/JWT decoding logic.

Changes

Object Short-Circuit for userinfo Decoding

Layer / File(s)	Summary
decodeUserInfoResponse object early-return mock-relying-party-service/utils.js	Inserts a guard at the start of decodeUserInfoResponse that detects non-null object inputs, logs the condition, and returns the payload directly instead of proceeding to JWE/JWT decoding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A bunny found the payload so neat,
Already an object, what a treat!
"No decode needed," the function cried,
Returns it straight, with rabbity pride,
🐇 Fast and simple, nothing to hide!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly references the main change: a bypass mechanism for handling JSON userInfoResponse instead of JWE/JWT tokens in the mock-relying-party-service.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@mock-relying-party-service/utils.js`:
- Around line 98-106: The condition at lines 98-106 in
mock-relying-party-service/utils.js uses
isJson(JSON.stringify(userInfoResponse)) which always evaluates to true since
JSON.stringify() produces valid JSON for any input, preventing the JWE/JWT
decoding logic below from executing. Replace this condition with a direct type
check to detect whether axios has already parsed userInfoResponse into a
JavaScript object (rather than leaving it as a string). After making this
type-check fix, remove the now-unused isJson helper function that appears at
lines 80-89.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2cbe9998-4a1d-40bf-a698-17b251137963

📥 Commits

Reviewing files that changed from the base of the PR and between 3fc8da6 and 3da6709.

⛔ Files ignored due to path filters (1)

• mock-relying-party-service/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

• mock-relying-party-service/utils.js