Fixed the required field validation error

[ghost]

Summary by CodeRabbit

• Documentation

  • Clarified update operation behavior for non-mandatory field validation.

• Refactor

  • Optimized identity schema validation error handling logic.

[coderabbitai]

Walkthrough

The pull request removes the explicit non-mandatory fields configuration from the mock identity system and refactors validation logic to dynamically derive error codes from validation messages instead of using a predefined configuration field. Documentation is updated to clarify that non-mandatory fields are validated only when present during updates.

Changes

Cohort / File(s)	Summary
Configuration Cleanup mock-identity-system/README.md, mock-identity-system/src/main/resources/application-default.properties	Removed explicit non-mandatory fields configuration. Updated documentation to explain non-mandatory field validation behavior during updates, replacing configuration reference with procedural description.
Validation Logic Refactor mock-identity-system/src/main/java/io/mosip/esignet/mock/identitysystem/validator/IdentitySchemaValidator.java	Removed nonMandatoryFieldsOnUpdate configuration injection; changed ignored error code from 1029 to 1028. Refactored error code generation to dynamically derive from validation messages via new helper method getErrorCodeFromValidationMessage().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hoppity hop, configs we drop!
Error codes dance to their own new beat,
No more hardcoded, now they're dynamic sweet,
Validation flows smooth, a refactored treat! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Fixed the required field validation error' is vague and does not clearly convey the specific changes made, which involve removing non-mandatory field configuration, adjusting error codes, and refactoring error code derivation logic.	Use a more specific title that describes the actual changes, such as 'Refactor field validation logic to derive error codes from validation messages' or 'Remove non-mandatory fields configuration and adjust error handling'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

mock-identity-system/README.md (1)

77-83: ⚠️ Potential issue | 🟡 Minor

Remove the stale reference to the deleted update config property.

Line 82 still references mosip.mock.ida.update-identity.non-mandatory.fields, but that property was removed. This makes the update-validation behavior unclear for users configuring the service.

Suggested README wording update

 How It Works
 * For create operations:
    1. The system validates all fields present in the identity data against the schema defined in mock-identity-schema.json.
 *  For update operations:
-   1. The system first validates all mandatory fields against the main schema.
-   2. Non-mandatory fields specified in mosip.mock.ida.update-identity.non-mandatory.fields are ignored during validation.
-   3. If the non-mandatory fields are present, they are validated against the  schema.
+   1. The system validates update payload fields against the main schema.
+   2. Missing optional fields are not treated as update errors.
+   3. Optional fields, when present in the payload, must satisfy schema constraints.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mock-identity-system/README.md` around lines 77 - 83, Remove the stale
reference to the deleted config property
mosip.mock.ida.update-identity.non-mandatory.fields in the "For update
operations" section and update the wording to reflect current behavior: state
that the system validates mandatory fields against mock-identity-schema.json and
that any optional/non-mandatory fields present in the payload are also validated
against the schema (no config toggle required); ensure the step list under "For
update operations" mentions validation of mandatory fields and validation of
present optional fields against mock-identity-schema.json, removing any mention
of the removed property.

🧹 Nitpick comments (1)

mock-identity-system/src/main/java/io/mosip/esignet/mock/identitysystem/validator/IdentitySchemaValidator.java (1)

68-68: Update the inline comment to match current logic.

Line 68 still says errors are ignored “for exempted fields,” but the field-based exemption path is no longer present. Keeping this comment will cause maintenance confusion.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@mock-identity-system/src/main/java/io/mosip/esignet/mock/identitysystem/validator/IdentitySchemaValidator.java`
at line 68, Update the misleading inline comment in IdentitySchemaValidator
(near the validation branch that ignores error code 1028) so it reflects the
current logic: state that validation errors with code 1028 (null value) are
ignored only when validating updateIdentity, and remove any mention of "exempted
fields" or field-based exemptions; update the comment text adjacent to the code
handling error code 1028 in the class to clearly describe this behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@mock-identity-system/src/main/java/io/mosip/esignet/mock/identitysystem/validator/IdentitySchemaValidator.java`:
- Around line 83-87: The method getErrorCodeFromValidationMessage currently
returns the literal "unknown_field" which isn't defined in the message/catalog;
replace that literal with the canonical fallback constant from ErrorConstants
(use the appropriate constant such as the project’s UNKNOWN_FIELD or
GENERIC_UNKNOWN_FIELD constant) so the validator returns a message key that
exists in messages.properties; update the return in
getErrorCodeFromValidationMessage to return ErrorConstants.<canonical_fallback>
(add the import if needed) and ensure messages.properties contains that key.
- Around line 67-71: The current UPDATE branch in IdentitySchemaValidator
unconditionally removes all errors with code "1028" (required-field violations);
change this to only ignore "1028" when the violation targets an exempted field
for updates: remove the broad filter on error.getCode().equals("1028") and
instead filter by both code and the specific field/path (e.g., inspect
error.getPath() or error.getMessage()) against your exemptedFields set so only
those required-field errors are suppressed; update the inline comment to
accurately state that 1028 represents missing required properties and that only
exemptions for specific fields during UPDATE are skipped.

---

Outside diff comments:
In `@mock-identity-system/README.md`:
- Around line 77-83: Remove the stale reference to the deleted config property
mosip.mock.ida.update-identity.non-mandatory.fields in the "For update
operations" section and update the wording to reflect current behavior: state
that the system validates mandatory fields against mock-identity-schema.json and
that any optional/non-mandatory fields present in the payload are also validated
against the schema (no config toggle required); ensure the step list under "For
update operations" mentions validation of mandatory fields and validation of
present optional fields against mock-identity-schema.json, removing any mention
of the removed property.

---

Nitpick comments:
In
`@mock-identity-system/src/main/java/io/mosip/esignet/mock/identitysystem/validator/IdentitySchemaValidator.java`:
- Line 68: Update the misleading inline comment in IdentitySchemaValidator (near
the validation branch that ignores error code 1028) so it reflects the current
logic: state that validation errors with code 1028 (null value) are ignored only
when validating updateIdentity, and remove any mention of "exempted fields" or
field-based exemptions; update the comment text adjacent to the code handling
error code 1028 in the class to clearly describe this behavior.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 05e812fa-3217-4f7f-9ff0-20895e93a936

📥 Commits

Reviewing files that changed from the base of the PR and between 43c8ad9 and 1ec3ff4.

📒 Files selected for processing (3)

• mock-identity-system/README.md
• mock-identity-system/src/main/java/io/mosip/esignet/mock/identitysystem/validator/IdentitySchemaValidator.java
• mock-identity-system/src/main/resources/application-default.properties

💤 Files with no reviewable changes (1)

• mock-identity-system/src/main/resources/application-default.properties