Skip to content

[MOSIP-44489] set active_profile_env to "default" in deployment (#558) - #560

Merged
1 commit merged into
mosip:developfrom
Infosys:sachin-dev
Mar 11, 2026
Merged

[MOSIP-44489] set active_profile_env to "default" in deployment (#558)#560
1 commit merged into
mosip:developfrom
Infosys:sachin-dev

Conversation

@sacrana0

@sacrana0 sacrana0 commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced configuration validation to ensure a default profile is automatically set when none is specified, improving system initialization reliability.

Signed-off-by: Sachin Rana <sacrana324@gmail.com>
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

Walkthrough

A shell script now includes a defensive guard ensuring the active_profile_env variable has a default value when unset. If empty, it prints an alert, assigns "default" as the fallback value, and exports it before proceeding with existing configuration logic.

Changes

Cohort / File(s) Summary
Shell Script Guard
mock-identity-system/configure_start.sh
Added defensive check to set active_profile_env to "default" if unset or empty, with corresponding alert message. Ensures variable initialization before downstream use.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops through scripts with care,
Checking if values are truly there,
When variables sleep, undefined and bare,
A gentle default fills the air! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a guard to set active_profile_env to 'default' in the deployment script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@mock-identity-system/configure_start.sh`:
- Around line 41-46: The guard that sets and exports the default for the
variable active_profile_env is placed after the script already reads that
variable; move the entire guard block that checks if active_profile_env is empty
(the if [[ -z "$active_profile_env" ]] ... export active_profile_env) to before
the first conditional that uses active_profile_env (the if [
"$active_profile_env" != "local" ] check), and remove the original duplicate
guard block where it currently resides so the script always evaluates with the
default applied.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8520079e-ce22-4204-a646-d43788370390

📥 Commits

Reviewing files that changed from the base of the PR and between ecc733e and acc0d51.

📒 Files selected for processing (1)
  • mock-identity-system/configure_start.sh

Comment thread mock-identity-system/configure_start.sh
@ghost
ghost merged commit 19537ce into mosip:develop Mar 11, 2026
20 checks passed
sacrana0 added a commit that referenced this pull request Aug 27, 2026
* Added PKCE implementation

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>

* fixed coderabbit comment

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>

* Corrected the logic to full dynamic identity schema

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* Fixed review comments

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* added proxy pass for par and dpop (#554)

Signed-off-by: Harsh Kashiwal <harsh.kashiwal@infosys.com>

* resolved comments

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>

* resolved review comment

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>

* resolve review comments

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>

* set active_profile_env to "default" in deployment (#558) (#560)

Signed-off-by: Sachin Rana <sacrana324@gmail.com>

* docs: fix typos, remove duplicate overview, and improve README formatting (#561) (#563)

Signed-off-by: Nandhukumar <nandhukumare@gmail.com>

* Added endpoint to fetch identity schema (#564)

* Added endpoint to fetch identity schema

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* Added endpoint to fetch identity schema

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* Fixed testcase

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

---------

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* Fixed the required field validation error (#565)

* Added endpoint to fetch identity schema

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* Added endpoint to fetch identity schema

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* Fixed required fields validation error

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

---------

Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>

* Snapshot updates 0.13.0 -> 0.13.1

Signed-off-by: Harsh Kashiwal <kashiwalharsh1234@gmail.com>

* [ES-2962] Added error messages for login_required and request_not_supported error.

Signed-off-by: GurukiranP <talk2gurukiran@gmail.com>

* [ES-1616] Added new error message.

Signed-off-by: GurukiranP <talk2gurukiran@gmail.com>

* [MOSIP-37808] Updated DB attributes of MOSIP esignet-mock

Signed-off-by: Abhi <abhishek.shankarcs@gmail.com>

* [MOSIP-37808] Updated DB attributes of MOSIP esignet-mock (#579)

Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>

* Updating sign-in-with-esignet, removing optional parameter from config (#590)

* [MODIFIED] used npm library for sign-in-with-esignet

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [MODIFIED] ignore optional parameter in sign-in-with-esignet

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [MODIFIED] readme file

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [MODIFIED] coderabbit comment resolved

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [MODIFIED] review comment addressed

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [MODIFIED] readme updated

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

---------

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [1996] added configurable token and userinfo endpoint (#591)

* [1996] added configurable token and userinfo endpoint

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [1996] add kid only, if private key has it

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [1996] default value of token & userinfo endpoint

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

---------

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [1966] bypass for json userInfoResponse (#592)

* [1966] bypass for json userInfoResponse

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [1966] bypass for json userInfoResponse

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

---------

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>

* [mosip/mosip-infra#1890] Added domainConfig support in helm charts (#589)

* [mosip/mosip-infra#1890] Removed esignet-global, added domainConfig support in helm charts

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

* [mosip/mosip-infra#1890] Set chart versions to 0.0.1-develop

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

* migrate to domainConfig helm values
 #1890

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

---------

Signed-off-by: bhumi46 <thisisbn46@gmail.com>
Co-authored-by: bhumi46 <bhumi11111a@gmail.com>

* Gpg update Test  (#596)

* ci: point kattu maven workflows at @develop to test kattu#353

Repoints maven-build / maven-publish-to-nexus / maven-sonar-analysis(-new)
reusable-workflow references to mosip/kattu@develop so the GPG-key-import
migration (mosip/kattu#353) is exercised by this repo's CI once it merges.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>

* ci: pass GPG_PRIVATE_KEY secret from caller workflows (kattu#353)

kattu#353 imports the signing key from the GPG_PRIVATE_KEY secret (now
required: true in maven-build / maven-publish-to-nexus workflow_call), so
the caller must forward it. Added GPG_PRIVATE_KEY to the maven-build and
maven-publish-to-nexus caller jobs only (sonar workflows don't declare it).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>

* ci: point maven workflows at Mahesh-Binayak/kattu@gpgupdate-masterj21

gpgupdate-masterj21 = master-java21 + the GPG-secret-import / key-age /
simplify4u-pgpverify changes, keeping master-java21's interface intact.
Repoints maven-build / maven-publish-to-nexus / maven-sonar-analysis to it,
restores MAVEN_NON_EXEC_ARTIFACTS, and forwards GPG_PRIVATE_KEY to the
build/publish jobs. Other workflows (docker-build, npm-*, sonar-new@develop)
and commented refs are left unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>

* ci: point maven workflows at mosip/kattu@gpgupdate-masterj21

The gpgupdate-masterj21 branch now lives on mosip/kattu; reference it
there instead of the fork. Interface unchanged; GPG_PRIVATE_KEY forwarded.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>

---------

Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

* [issue:1963] Updated helm for thunder deployment (#593)

Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>

* [issue:597] Add PKCS12 keystore support to mock-identity-system as an alternative to SoftHSM (#599)

install.sh now prompts to opt into a PKCS12 mounted-volume keystore instead
of SoftHSM; SoftHSM provisioning only runs when PKCS12 isn't selected. The
chart gained a PersistentVolumeClaim template, a fixed volume-permissions
init container (was a literal unfilled placeholder), persistence volume
wiring in the deployment, and additive extraEnvVarsAdditional support.

Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>

* Fix default prompt value (#600)

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>
Co-authored-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>

* #10670: Add AGENTS.md tree for AI coding assistant guidance

Adds a root AGENTS.md hub covering the repository as a whole, plus
per-module AGENTS.md guides for mock-identity-system,
mock-relying-party-service, mock-relying-party-ui,
mock-relying-party-ui-esim, and partner-onboarder — the independently
buildable modules in this repo. Each guide documents purpose, layout,
how to run/build/test, configuration, and explicit agent do/do-not
rules, verified against the actual READMEs, pom.xml/package.json
files, and GitHub Actions workflows in this repo.

Addresses mosip/mosip-config#10670

Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>

* #10670: Address CodeRabbit review feedback on AGENTS.md

- Stop prescribing npm test for every Node/React module; point to
  each module's own AGENTS.md/README.md since scripts differ
  (mock-relying-party-service has no test script at all).
- Fix docker-compose path in mock-identity-system/AGENTS.md: from the
  repo root it's docker-compose/, not ../docker-compose/.
- Use MOCK_RELYING_PARTY_SERVER_URL in the mock-relying-party-ui-esim
  Docker example, matching the variable the Dockerfile/UI actually
  read (MOCK_RELYING_PARTY_BASE_URL has no effect).
- Note that partner-onboarder targets a non-production eSignet
  deployment only, per the root README's repo-wide scope.

Addresses review comments on #601

Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>

* fix: 602 convert extraEnvVars/extraEnvVarsAdditional to maps (#603)

* fix: 602 convert extraEnvVars/extraEnvVarsAdditional to maps

Helm merges map keys across values layers but replaces lists wholesale,
so any downstream override of extraEnvVars/extraEnvVarsAdditional had
to re-declare the whole list just to change one entry. Convert both to
maps keyed by env var name in mock-identity-system,
mock-relying-party-service, and mock-relying-party-ui, and render them
with a range loop that auto-detects plain scalars vs. valueFrom,
matching the existing domainConfig pattern already used in these
charts. Same fix already applied to mosip/esignet (issue #2380).

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

* fix: 602 update mock-identity-system installer for extraEnvVarsAdditional map contract

deploy/mock-identity-system/install.sh generated extraEnvVarsAdditional
as a list in two places (PKCS12 and softhsm branches), which produced
broken index-keyed env entries against the chart's map-shaped default
introduced in this PR. Convert both to the map contract (KEY: value /
KEY: {valueFrom: ...}), matching the fix already applied to esignet's
legacy installer scripts.

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

---------

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

* Change image tag from release-0.10.x to develop

Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>

* Change image tag from release-0.10.x to develop

Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>

* Change image tag from release-0.10.x to develop

Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>

* #2347 Update database host and clean up configuration (#610)

Updated the host to include the namespace and removed unused service configurations.

Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>

* #2347 Update database username in postgres config (#611)

* #2347 Update database username in postgres config

Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>

* #2347 Update database username in deploy.properties

Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>

---------

Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>

* updated version 0.13.0 to 0.14.0

Signed-off-by: Sachin Rana <sacrana324@gmail.com>

* updated helm chart version

Signed-off-by: Sachin Rana <sacrana324@gmail.com>

---------

Signed-off-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>
Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>
Signed-off-by: Harsh Kashiwal <harsh.kashiwal@infosys.com>
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
Signed-off-by: Harsh Kashiwal <kashiwalharsh1234@gmail.com>
Signed-off-by: GurukiranP <talk2gurukiran@gmail.com>
Signed-off-by: Abhi <abhishek.shankarcs@gmail.com>
Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>
Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>
Signed-off-by: bhumi46 <thisisbn46@gmail.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Co-authored-by: Sajid Mannikeri <sajid.mannikeri@ad.infosys.com>
Co-authored-by: ase-101 <sunkadaeanusha@gmail.com>
Co-authored-by: Zeeshan Mehboob <82993262+zesu22@users.noreply.github.com>
Co-authored-by: Harsh Kashiwal <77677724+KashiwalHarsh@users.noreply.github.com>
Co-authored-by: Nandhukumar <nandhukumare@gmail.com>
Co-authored-by: Harsh Kashiwal <kashiwalharsh1234@gmail.com>
Co-authored-by: GurukiranP <talk2gurukiran@gmail.com>
Co-authored-by: Abhi <abhishek.shankarcs@gmail.com>
Co-authored-by: Chandra Keshav Mishra <chandrakeshavmishra@gmail.com>
Co-authored-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>
Co-authored-by: bhumi46 <111699703+bhumi46@users.noreply.github.com>
Co-authored-by: bhumi46 <bhumi11111a@gmail.com>
Co-authored-by: Mahesh-Binayak <76687012+Mahesh-Binayak@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Praful Rakhade <prafulrakhade02@gmail.com>
Co-authored-by: Swapnil <swapnil.mohanty@technoforte.co.in>
Co-authored-by: Sajid Mannikeri <sajid.mannikeri@infosys.com>
Co-authored-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant