[MONGOCRYPT-434] Rename "csfle" to "crypt_shared" #352
Conversation
This commit changes almost all references of the "csfle" dynamic library to "crypt_shared", as per DRIVERS-2338/MONGOCRYPT-434. This change includes renames to both the public and internal API references. Some filenames and test names remain unchanged.
vector-of-bool
requested review from
ShaneHarvey,
addaleax,
baileympearson,
blink1073,
dariakp,
durran,
juliusgeo and
nbbeeken
as code owners
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM. Please wait to merge until the new shared library is available to download to ensure tests pass.
| if (options.extraOptions && options.extraOptions.csflePath) { | ||
| mongoCryptOptions.csflePath = options.extraOptions.csflePath; | ||
| if (options.extraOptions && options.extraOptions.cryptSharedLibPath) { | ||
| mongoCryptOptions.cryptSharedLibPath = options.extraOptions.cryptSharedLibPath; |
There was a problem hiding this comment.
Thank you for addressing this as well! 💙
@nbbeeken @durran @dariakp @baileympearson Heads up that this is a breaking change from 2.1.0 – that should be okay on our side, and I don’t think the team really announced shared library support, so I’d be okay with not introducing aliases here.
I’ve opened mongodb/node-mongodb-native#3280 to adjust the typings.
|
6.0.0-rc8 has been released and the csfle library has been renamed to crypt_shared in http://downloads.mongodb.org/full.json. There are many reviewers listed on the shared library rename for libmongocrypt: #352 from the code owners. Since the change is a rename, I am to merging this now to unblock the libmongocrypt 1.5.0-rc0 release. |
3 participants
This changeset replaces almost all references of the "csfle" dynamic library
with "crypt_shared", as per DRIVERS-2338/MONGOCRYPT-434.
This change includes renames to both the public and internal API
references. Some filenames and test names remain unchanged.
Also see: mongodb/specifications#1236
This change also includes updates to the Node and Python bindings to use the new names and APIs
Note: Using these changes depend on updates to the downloads manifest that will also rename the
csfleartifact tocrypt_shared. The changes have so far been manually verified by using amongo_crypt_v1.solibrary downloaded by hand.